Skip to content

Convert golden tests to tasty-golden #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pepeiborra opened this issue Jul 12, 2020 · 2 comments
Closed

Convert golden tests to tasty-golden #192

pepeiborra opened this issue Jul 12, 2020 · 2 comments

Comments

@pepeiborra
Copy link
Collaborator

I think using utilities from tasty-golden is better in terms of golden file management (it allows us to update golden file automatically).

Originally posted by @Ailrun in #191
@jneira
Copy link
Member

jneira commented Oct 22, 2020 •
edited
Loading

It seems 67744c4 changed eval plugin tests to make it use golden files, ¿do more tests need be changed to use tasty-golden?

@jneira jneira added the status: needs info Not actionable, because there's missing information label Oct 22, 2020
@jneira jneira removed the status: needs info Not actionable, because there's missing information label Nov 9, 2020
@jneira
Copy link
Member

jneira commented Nov 9, 2020

It seems all golden tests are using tasty-golden so we could close this. Feel free to reopen the issue it is not the case (with pointers to concrete tests if possible)

@jneira jneira closed this as completed Nov 9, 2020
pepeiborra pushed a commit that referenced this issue Dec 27, 2020
@jinwoo @aherrmann-da
Support plugins (#192)
3bec234 
* Support plugins

Call initializePlugins before running typecheck.

* call initializePlugins only for GHC >= 8.6

initializePlugins doesn't exist in older GHC versions.

* A separate function for initializing plugins

* Add a test for plugins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pepeiborra @jneira