Skip to content

Fix #190 - update flask example version #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Nabellaleen
Copy link
Collaborator

Fix #190

The flask example were also broken by useless EmployeeConnection class conflicting with the class automatically created by graphene-sqlalchemy due to the back-populate from department to employees

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.877% when pulling faadf03 on Nabellaleen:fix-190-update-flask-example-version into c3f175f on graphql-python:master.

@Nabellaleen Nabellaleen requested review from Cito and jnak March 30, 2019 23:39
Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely for me.

See #194 for more things that could be improved here.

@jnak jnak merged commit 46c9eb7 into graphql-python:master Apr 1, 2019
@Nabellaleen Nabellaleen added this to the 2.1.1 milestone Apr 1, 2019
@Nabellaleen Nabellaleen deleted the fix-190-update-flask-example-version branch April 1, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants