Skip to content

Fix Travis integration, set up tox and pre-commit #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2019
Merged

Fix Travis integration, set up tox and pre-commit #188

merged 2 commits into from
Mar 29, 2019

Conversation

jnak
Copy link
Collaborator

@jnak jnak commented Mar 29, 2019

This PR fixes our CI integration:

  • It uses tox to run our tests against different supported versions of python and SQLAlchemy.
  • This pin points specific versions of our test dependencies to make our builds reproductible.
  • Linters are now run as pre-commit hooks.

jnak
jnak commented Mar 29, 2019
View reviewed changes
.pre-commit-config.yaml
- id: check-merge-conflict
- id: check-yaml
- id: debug-statements
# TDOO Enable in separate PR
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix all the linting issues in a separate PR.

jnak
jnak commented Mar 29, 2019
View reviewed changes
setup.cfg
@@ -2,28 +2,9 @@
exclude = setup.py,docs/*,examples/*,tests
max-line-length = 120

[coverage:run]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already a .coveragerc file

setup.cfg
[coverage:run]
omit = */tests/*

# TODO Add isort as a pre-commit hook
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI This was not doing anything

@Nabellaleen Nabellaleen requested review from Nabellaleen and Cito March 29, 2019 17:32
Nabellaleen
Nabellaleen approved these changes Mar 29, 2019
View reviewed changes
Copy link
Collaborator

@Nabellaleen Nabellaleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So great ! Thank you so much @jnak ;)

@jnak jnak merged commit 8a2f020 into graphql-python:master Mar 29, 2019
@Nabellaleen Nabellaleen added this to the 2.1.1 milestone Mar 29, 2019
@Nabellaleen Nabellaleen mentioned this pull request Mar 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nabellaleen Nabellaleen Nabellaleen approved these changes

@Cito Cito Awaiting requested review from Cito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jnak @Nabellaleen