Add support for minimum batch size #77
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces two new options in DataLoaderOptions: minBatchSize and maxWaitTimeInMillis. These options helps to configure minimum batch size to be formed before it is passed to BatchLoader. This is particularly helpful in scenarios where applications do not have control on when to call dispatch() method (for example, GraphQL). Both of these parameters need to be configured in order to achieve minimum batch. Configuring only one parameter will have the same impact of not configuring at all.
This was referenced Jun 25, 2021
bbakerman
reviewed
Jun 27, 2021
| @@ -69,6 +79,8 @@ Object getCallContext() { | |||
| this.futureCache = futureCache; | |||
| this.loaderQueue = new ArrayList<>(); | |||
| this.stats = stats; | |||
| this.lastDispatchTime = Instant.now(); | |||
| this.executorService = Executors.newSingleThreadScheduledExecutor(); | |||
There was a problem hiding this comment.
Data load should not do any threading. This might be suitable for some use cases but say in a reactive app this executor is not controlled or warranted.
If we did put an executor into the DataLoader then it would need to be passed in not created
I would rather see some sort of helper that can dispatch a dataloader if its not been dispatched for more than N seconds
So I like the fact this has time since last dispatch and so on. But it Must not do the actual dispatcing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minBatchSizeandmaxWaitTimeInMillis.