Skip to content

fix content length on batched queries #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2020
Merged

fix content length on batched queries #231

merged 1 commit into from
Feb 18, 2020

Conversation

fliptaboada
Copy link
Contributor

Related to #220 but for batched queries
Also updated the tests to check contentLength accordingly.

vojtapol
vojtapol requested changes Feb 18, 2020
View reviewed changes
Copy link
Member

@vojtapol vojtapol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question before we merge.

Is this the right way to go about it? Can we guarantee the response content is always in UTF8?

@fliptaboada
Copy link
Contributor Author

The contentType is always set as application/json;charset=UTF-8.

vojtapol
vojtapol approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@vojtapol vojtapol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 🎉

@vojtapol vojtapol merged commit f0bca9f into graphql-java-kickstart:master Feb 18, 2020
@fliptaboada fliptaboada deleted the fix-batched-content-length branch February 19, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtapol vojtapol vojtapol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fliptaboada @vojtapol