-
Notifications
You must be signed in to change notification settings - Fork 113
Update OSGi example project #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi Serge, When I execute ./gradlew publishToMavenLocal, I get... Could I be missing something? There was a comment next to gradlew.bat in the Github file listing that said "Problem: compileOnly doesn't work on older Gradle" so I upgraded to Gradle 5.4 but it doesn't seem to help. Thanks, Peter Stacktrace:peter@peter-VirtualBox:~/osgi/graphql-java-servlet-master$ ./gradlew publishToMavenLocal --stacktrace
FAILURE: Build failed with an exception.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0. BUILD FAILED in 7s |
I can't reproduce this problem. Here's what a build looks like on my machine :
|
- Add description to hello field.
Also I'm not sure what you mean by you upgraded to Gradle 5.6. By default the wrapper downloads version 3.5 which is the version the project uses, this has nothing to do with the OSGi example anyway. How are you changing this version and why? Are you modifying the gradle-wrapper.properties ? I think that this should then be reported as an issue with the global project, not the OSGi example. |
Hi Serge, I haven't modified the gradle-wrapper.properties yet at all. I just want to get the basic example working and then iterate from there especially since I'm not a gradle or bndtools expert. I upgraded to gradle 5.4.0 only because I keep getting the error below and thought that would fix it. Which version of Java are you using? The main project said that it's compatible with Java 11 but maybe not the example? Thanks for helping me. I really appreciate it. I'm trying to build a GraphQL endpoint for a back-end data source that undergoes continual change. Nothing but a dynamic schema will work for my particular application. Peter Error:**C:\osgi-serge>gradlew publishToMavenLocal FAILURE: Build failed with an exception.
|
Hi Serge, In reference to the post that I made prior to this one, I did remove gradle 5.4 and let the wrapper download gradle 3.5 but it still doesn't like Java 11. Guess the thing to do is to restore to a prior version of Java? Thanks, Peter |
Ok thanks for giving me the context, but again this has nothing to do with the OSGi example this is a main project (graphql-java-servlet) issue. I see that you have opened issues there so let's continue over there. I would prefer we stay on topic for this PR that is only there to improve the example and modernize it. |
Understood. I'll switch over to the main project to continue our conversation. Since you got the OSGi example working, the problem can't be the example. |
To my knowledge there are no issues reported (above conversation was about issues with Java 11 that are not related to this commit). Can this PR be merged now ? |
@sergehuber Thanks for the contribution! |
Hello,
I have updated the OSGi example project to make it work properly.
Let me know if you have any questions.
Regards,
Serge...