Skip to content

Should override javax.servlet.GenericServlet.init() instead of javax.servlet.GenericServlet.init(ServletConfig) in AbstractGraphQLHttpServlet #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sammyhk opened this issue May 7, 2019 · 0 comments
Milestone

Comments

@sammyhk
Copy link
Contributor

sammyhk commented May 7, 2019

Should override javax.servlet.GenericServlet.init() instead javax.servlet.GenericServlet.init(ServletConfig) or at least overriding javax.servlet.GenericServlet.init(ServletConfig) should call super.init(ServletConfig) in AbstractGraphQLHttpServlet (

public void init(ServletConfig servletConfig) {
).

Now subclass of it cannot call getServletConfig()/ getServletName() due to missing of calling super.init(ServletConfig)

sammyhk added a commit to sammyhk/graphql-java-servlet that referenced this issue May 7, 2019
…() instead of javax.servlet.GenericServlet.init(ServletConfig)
oliemansm added a commit that referenced this issue May 21, 2019
#175 override javax.servlet.GenericServlet.init() instead of javax.se…
@oliemansm oliemansm added this to the 7.5.0 milestone May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants