Fix Android Resolver unable to resolve mainTemplate.gradle in Unity 2022.2+ or 2023.1+ #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Later version of Unity (2022.2+ or 2023.1+) changed the way to specify Android Gradle plugin version. As a result, `AndroidGradlePluginVersion` getter would fail to find the version and Android Resolver would fail when `mainTemplate.gradle` is in use. This fix searches Android Gradle plugin version using two regex to ensure Android Resolver can find the version in any Unity version.
…icationIdentifier()
chkuang-g
force-pushed
the
patch/gradle-plugin-version
branch
from
e16268e to
6001cb4
Compare
DellaBitta
approved these changes
Oct 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android Resolver fails when
mainTemplate.gradleis used in Unity 2022.2+ or 2023.1+This is primary due to
PlayServiceResolver.AndroidGradlePluginVersionproperty failed to find the the plugin version because the line is changed fromto
This fix make sure the property getter use both pattern to find the version number.