[Bug] unexpected char: '\' when using project export

[andreimamlay]

[REQUIRED] Please fill in the following fields:

• Unity editor version: 2021.1.16f1
• External Dependency Manager version: 1.2.168
• Source you installed EDM4U: .unitypackage
• Features in External Dependency Manager in use: Android Resolver
• Plugins SDK in use: Firebase, GoogleSignIn
• Platform you are using the Unity editor on: Windows

[REQUIRED] Please describe the issue here:

1. Install Firebase from .unitypackage
2. Enable

• Custom Main Gradle Template
• Custom Launcher Gradle Template
• Custom Gradle Properties Template

3. Export project
4. Open unityLibrary/build.gradle
5. See incorrect path in local maven url

Please answer the following, if applicable:

100%

Caused by the following code in PlayServicesResolver.cs

// If "Export Gradle Project" setting is enabled, gradle project expects
// absolute path.
if (exportEnabled) {
    repoUri = String.Format("\"{0}\"",
                            Path.Combine(projectFileUri, repoPath));
}

For example, Path.Combine("file:///C:/Unity/TestGame", "Assets/GeneratedLocalRepo/Firebase/m2repository") produces file:///C:/Unity/TestGame\Assets/GeneratedLocalRepo/Firebase/m2repository

[google-oss-bot]

This issue does not seem to follow the issue template. Make sure you provide all the required information.

[paulinon]

Hi @andreimamlay,

Thanks for reporting this, @andreimamlay. Version 1.2.169 of the resolver has been released recently. Could you confirm if the issue persists using that version as well?

[andreimamlay]

Thank you for your time, @paulinon .

I have

1. updated external dependency manager (using external-dependency-manager-1.2.169.unitypackage)
2. forced resolve

and can confirm, that issue remains: incorrect path delimiter is inserted into maven.url configuration

In master branch the following code still remains and causes incorrect delimiter on windows platform

unity-jar-resolver/source/AndroidResolver/src/PlayServicesResolver.cs

Lines 2146 to 2147 in 8d9505b

	repoUri = String.Format("\"{0}\"",
	Path.Combine(projectFileUri, repoPath));

Changing said line to

repoUri = String.Format("\"{0}\"",
                        Path.Combine(projectFileUri, repoPath).Replace("\\", "/"));

would fix the problem on windows platform

[paulinon]

Thanks for the information, @andreimamlay. I was able to observe this behavior on a Windows platform as well.

I'll let the team know about this. That being said, I'll be marking this as a bug for now.

[andreimamlay]

There was a PR for this issue!

#421

[andreimamlay]

@paulinon
Could you please look again at this issue?

[chkuang-g]

#421 was merged. I am preparing a new release of EDM4U once I got another patch in.

If you need the patch soon, you can rebuild EDM4U using

# Build .unitypackage
./gradlew buildPlugin

# Build .tgz
./gradlew buildUPMPlugin