Patch float with trailing zero for JSON and add useFloatWithTrailingZero flag #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenhuiyeh
changed the title
|
It would be good to add some tests and a description or an issue link. |
chenhuiyeh
changed the title
| // Type assert to RowsEvent | ||
| rowsEvent := evt.Event.(*RowsEvent) | ||
| for _, row := range rowsEvent.Rows { | ||
| // The third row should contain our test values |
chenhuiyeh
force-pushed
the
float_with_trailing_zero
branch
from
814aa96 to
9d46fb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have patched go-mysql to keep trailing zero in floats in json: Shopify/ghostferry#368
This will only work with mysql version 8 onwards. To enable this,
useFloatWithTrailingZerosetting option has been added.Part of Shopify/ghostferry#384