Fix: charset latin1 #1036
Open
Fix: charset latin1 #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests Removed FlushBinlog which was only used for testing
…deleted_while_reading Fix/eitam/add skip when table is deleted while reading
Feature/eitam/removed spamming log
…_decode Added support to convert byte to string dynamically
…on_sp Remove unneeded log on SP
…_to_date Change mysql_date default zero based value to nil
…_to_date Change mysql_MYSQL_TYPE_TIMESTAMP2 and MYSQL_TYPE_TIMESTAMP to be def…
…_to_date Change decodeDatetime2 default to zero
Change decodeTimestamp2 to return nil in case sec = 0
Add limit to max host name length
…p_log Changed SP is missing to debug level
feat: Charset parameter for Mysql connection [DEV-13143]
|
@sigalikanevsky There are merge conflicts that need to be fixed. This is also missing either a link to an issue or a good description about what this is fixing exactly. Is this only fixing |
serprex
reviewed
May 22, 2025
| @@ -65,6 +65,10 @@ func NewCanal(cfg *Config) (*Canal, error) { | |||
|
|
|||
| c.ctx, c.cancel = context.WithCancel(context.Background()) | |||
|
|
|||
| if cfg.WaitTimeBetweenConnectionSeconds > 0 { | |||
There was a problem hiding this comment.
this seems odd, why replace all configs with 5 seconds?
serprex
reviewed
May 22, 2025
| @@ -142,7 +143,15 @@ func (c *Canal) runSyncBinlog() error { | |||
| case *replication.QueryEvent: | |||
| stmts, _, err := c.parser.Parse(string(e.Query), "", "") | |||
| if err != nil { | |||
| log.Errorf("parse query(%s) err %v, will skip this event", e.Query, err) | |||
| msg := err.Error() | |||
| if strings.Contains(strings.ToLower(msg), strings.ToLower("procedure")) { | |||
There was a problem hiding this comment.
Suggested change
| if strings.Contains(strings.ToLower(msg), strings.ToLower("procedure")) { | |
| if strings.Contains(strings.ToLower(msg), "procedure") { |
serprex
reviewed
May 22, 2025
| @@ -697,7 +707,8 @@ func (b *BinlogSyncer) onStream(s *BinlogStreamer) { | |||
| return | |||
| } | |||
|
|
|||
| log.Errorf("retry sync err: %v, wait 1s and retry again", err) | |||
| log.Errorf("retry sync err: %v, wait %s s and retry again", err, b.cfg.WaitTimeBetweenConnectionSeconds) | |||
There was a problem hiding this comment.
Suggested change
| log.Errorf("retry sync err: %v, wait %s s and retry again", err, b.cfg.WaitTimeBetweenConnectionSeconds) | |
| log.Errorf("retry sync err: %v, wait %ss and retry again", err, b.cfg.WaitTimeBetweenConnectionSeconds) |
serprex
reviewed
May 22, 2025
| @@ -1182,6 +1220,33 @@ func decodeString(data []byte, length int) (v string, n int) { | |||
| return | |||
| } | |||
|
|
|||
| // Replaces smart quotes with ASCII equivalents | |||
| func replaceUnsupportedLatin1Characters(s string) string { | |||
| s = string(bytes.ReplaceAll([]byte(s), []byte("‘"), []byte("'"))) | |||
There was a problem hiding this comment.
Should avoid repeatedly converting to/from string
serprex
reviewed
May 22, 2025
| @@ -1182,6 +1220,33 @@ func decodeString(data []byte, length int) (v string, n int) { | |||
| return | |||
| } | |||
|
|
|||
| // Replaces smart quotes with ASCII equivalents | |||
| func replaceUnsupportedLatin1Characters(s string) string { | |||
There was a problem hiding this comment.
Suggested change
| func replaceUnsupportedLatin1Characters(s string) string { | |
| func replaceUnsupportedLatin1Characters(s []byte) string { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.