Fix android react native release builds stacktrace #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvinegar
approved these changes
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically this PR with a test: #950
Thx @yury
It seems that if you build a react native android app in release, the stacktrace has a special format.
This PR fixes the regex we have.
Also discussed this with @mitsuhiko, this PR is the faster, a bit more hacky solution.
I didn't dare to refactor the whole
computeStackTraceFromStackPropfunction.Someday we could refactor it like:
before we iterate every line and check which regex matches, we could first detect what kind of stacktrace it is and then just use the specific regex.
Nevertheless, tested it also in a real react-native app and it works.
Before:
After:
