Vendor+IE8-ify json-stringify-safe, fix handler with XDomainRequest #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvinegar
approved these changes
Mar 14, 2017
| } | ||
| if (opts.onError) { | ||
| request.onerror = function () { | ||
| var err = new Error('Sentry error code: XDomainRequest'); |
There was a problem hiding this comment.
I quickly experimented w/ having a helper onerror function that could be called from either the XDomainRequest handler or onreadystatechange, but it quickly ended up taking up more code so nm ...
benvinegar
approved these changes
Mar 20, 2017
This was referenced Mar 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fully address #881. There were two symptoms each with a separate root issue:
Object doesn't support this property or methodwhen sending messages/exceptionsArray.prototype.indexOfArray.prototype.indexOfrequestobject doesn't have astatusattribute which we were expecting/relying on, andXDR.onloadonly fires in success cases (error cases useonerror)._makeRequestI pieced this into several separate commits to make it easy to see our modifications relative to the vendored originals.
/cc @benvinegar