captureMessage can attach stack trace via `stacktrace: true` option #582

benvinegar · 2016-05-17T04:09:14Z

See also #581

not by default, must specify new option: { stacktrace: true }
this can be passed directly to individual captureMessage calls, or set globally during config
overrides grouping/fingerprint so that stack trace doesn't change existing behavior
- good idea? makes sense when user intentionally calls captureMessage, but maybe not if captureMessage was the result of a failed captureException call (e.g. bad error object)
fixes Ability to specify stack: true when calling captureMessage #544
fixes Custom exceptions throw globally aren't filtered by whitelistUrls #503 (since attached stack trace will include URLs that filters can/will reject)

cc @mattrobenolt @mitsuhiko @dcramer @bradvogel

This change is

mattrobenolt · 2016-05-18T19:46:26Z

Let's use the sentry.interface.Stacktrace interface explicitly and avoid sending along an Exception interface for the synthetic exception.

benvinegar · 2016-07-01T00:27:17Z

Let's use the sentry.interface.Stacktrace interface explicitly and avoid sending along an Exception interface for the synthetic exception.

I mean, this is ideal, but to do so means a colossal refactor of Raven.js :( Let me dork around and see what it looks like.

benvinegar · 2016-07-01T22:54:41Z

Example of Raven.captureMessage('lol', { stacktrace: true }) in the UI (triggered from console so no source maps etc):

Edit: hmm, should have marked those Raven frames as in_app.

benvinegar · 2016-07-01T23:01:53Z

Gruntfile.js

@@ -131,7 +131,7 @@ module.exports = function(grunt) {
                dest: 'build/raven.test.js',
                options: {
                browserifyOptions: {
-                    debug: true // source maps
+                    debug: false// source maps


Source map generation for tests is/has been broken so I just disabled it to make my life easier debugging this. I'll revisit in future.

Sija · 2016-07-07T01:07:17Z

src/raven.js

@@ -363,6 +363,8 @@ Raven.prototype = {
                ex = ex1;
            }

+            console.log(ex.stack);


Got it, thanks.

benvinegar · 2016-07-28T01:16:48Z

This is no longer WIP. My plan is to test this live on app.getsentry.com for a short while, then we'll roll it into 3.4.0.

simon-weber · 2016-08-20T17:58:23Z

@benvinegar Any updates on this? This would be a huge help for me 😁

benvinegar · 2016-08-24T22:22:31Z

@simon-weber yep trying to push this through. Big changes like this make me nervous so I just need to QA ourselves first.

/cc @getsentry/team

…xample

benvinegar · 2016-08-26T21:59:11Z

Okay, after some testing I've decided that attempting figure out the "tail" Raven frames has more cases than I've considered, so I've reverted that part of the code.

This now strictly just does synthetic stack traces via Raven.captureMessage (or as a fallback if captureException is given a string or non-error).

cc @mattrobenolt @macqueen – can you look at this again?

benvinegar · 2016-08-26T22:00:51Z

src/raven.js

+            options = objectMerge({
+                // fingerprint on msg, not stack trace
+                // NOTE: need also to do this because stack could include Raven.wrap,
+                //       which may create inconsistent traces if only using window.onerror


Not sure I understand this comment anymore (re window.onerror) ... uhhhh

¯_(ツ)_/¯

Ah, that comment was true until I added the trimHeadFrames stuff.

macqueen · 2016-08-26T22:47:33Z

Reviewed 2 of 3 files at r6, 3 of 3 files at r7.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

Comments from Reviewable

macqueen · 2016-08-26T22:49:03Z

Reviewed 1 of 1 files at r8.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

wearhere · 2016-08-27T01:01:13Z

Cool! What version is this targeting? We're past 3.4.0 now.

benvinegar · 2016-08-27T01:03:09Z

3.6.0.

…etsentry#582)

benvinegar force-pushed the capturemessage-stacktrace branch from 0a0ebf9 to c4956d0 Compare May 17, 2016 04:11

benvinegar force-pushed the capturemessage-stacktrace branch from c4956d0 to 407848e Compare July 1, 2016 00:20

benvinegar reviewed Jul 1, 2016
View reviewed changes

benvinegar force-pushed the capturemessage-stacktrace branch from ecb0205 to 7fbf87b Compare July 6, 2016 00:01

Sija reviewed Jul 7, 2016
View reviewed changes

benvinegar force-pushed the capturemessage-stacktrace branch from 9403f01 to 310280d Compare July 7, 2016 02:03

benvinegar changed the title ~~captureMessage can attach stack trace via stacktrace: true option [WIP]~~ captureMessage can attach stack trace via stacktrace: true option Jul 28, 2016

benvinegar force-pushed the capturemessage-stacktrace branch from 310280d to 722492b Compare July 28, 2016 01:12

benvinegar added 6 commits August 24, 2016 15:22

Strip Raven's wrapped try/catch call from frames

a8c717f

captureMessage can attach stack trace via stacktrace: true

6dc5dcb

Pass stacktrace via captureMessage as stacktrace interface

ae422e9

Bad method name

df508d4

First pass at tests

1df1c94

Fix test for PhantomJS

22bebbd

benvinegar force-pushed the capturemessage-stacktrace branch from 722492b to 22bebbd Compare August 24, 2016 22:22

benvinegar added a commit to getsentry/sentry that referenced this pull request Aug 24, 2016

Bump raven-js dependency to test getsentry/sentry-javascript#582

b35873c

/cc @getsentry/team

benvinegar added a commit to getsentry/sentry that referenced this pull request Aug 24, 2016

Bump raven-js dependency to test getsentry/sentry-javascript#582 (#4004)

1d89dd8

/cc @getsentry/team

Remove tail frame trimming (too many edge cases atm), add synthetic e…

612fe95

…xample

benvinegar reviewed Aug 26, 2016
View reviewed changes

Update comment re: msg fingerprint

31bedfe

Wrong logic for trimHeadFrames, fix tests

9cc1a71

benvinegar merged commit e8040b1 into master Aug 26, 2016

benvinegar deleted the capturemessage-stacktrace branch August 26, 2016 23:46

romainneutron mentioned this pull request Oct 18, 2016

stacktrace:true not available in global config #743

Closed

benvinegar mentioned this pull request Nov 18, 2016

Strip Raven's wrapped try/catch call from frames [WIP] #581

Closed

denstepa pushed a commit to denstepa/raven-js that referenced this pull request Jan 5, 2017

captureMessage can attach stack trace via stacktrace: true option (g…

7b350ef

…etsentry#582)

JAStanton mentioned this pull request Aug 18, 2017

Support for stacktrace: true getsentry/sentry-react-native#201

Closed

2 tasks

kamilogorek mentioned this pull request Mar 8, 2022

ref(minimal): Simplify syntheticException creation #4691

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

captureMessage can attach stack trace via `stacktrace: true` option #582

captureMessage can attach stack trace via `stacktrace: true` option #582

benvinegar commented May 17, 2016 •

edited by dcramer

Loading

mattrobenolt commented May 18, 2016

benvinegar commented Jul 1, 2016 •

edited

Loading

benvinegar commented Jul 1, 2016 •

edited

Loading

benvinegar Jul 1, 2016

Sija Jul 7, 2016

benvinegar Jul 28, 2016

benvinegar commented Jul 28, 2016

simon-weber commented Aug 20, 2016

benvinegar commented Aug 24, 2016

benvinegar commented Aug 26, 2016

benvinegar Aug 26, 2016

macqueen Aug 26, 2016

benvinegar Aug 26, 2016

macqueen commented Aug 26, 2016

macqueen commented Aug 26, 2016

wearhere commented Aug 27, 2016

benvinegar commented Aug 27, 2016

captureMessage can attach stack trace via stacktrace: true option #582

captureMessage can attach stack trace via stacktrace: true option #582

Conversation

benvinegar commented May 17, 2016 • edited by dcramer Loading

mattrobenolt commented May 18, 2016

benvinegar commented Jul 1, 2016 • edited Loading

benvinegar commented Jul 1, 2016 • edited Loading

benvinegar Jul 1, 2016

Choose a reason for hiding this comment

Sija Jul 7, 2016

Choose a reason for hiding this comment

benvinegar Jul 28, 2016

Choose a reason for hiding this comment

benvinegar commented Jul 28, 2016

simon-weber commented Aug 20, 2016

benvinegar commented Aug 24, 2016

benvinegar commented Aug 26, 2016

benvinegar Aug 26, 2016

Choose a reason for hiding this comment

macqueen Aug 26, 2016

Choose a reason for hiding this comment

benvinegar Aug 26, 2016

Choose a reason for hiding this comment

macqueen commented Aug 26, 2016

macqueen commented Aug 26, 2016

wearhere commented Aug 27, 2016

benvinegar commented Aug 27, 2016

captureMessage can attach stack trace via `stacktrace: true` option #582

captureMessage can attach stack trace via `stacktrace: true` option #582

benvinegar commented May 17, 2016 •

edited by dcramer

Loading

benvinegar commented Jul 1, 2016 •

edited

Loading

benvinegar commented Jul 1, 2016 •

edited

Loading