-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(build): Add JS polyfills to utils tarball #5029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c5d391
to
6dda61c
Compare
size-limit report 📦
|
6dda61c
to
9b564f8
Compare
Because of changes in #5051, this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: This is no longer necessary, and is therefore getting closed.
This is a follow-up to #5023, which introduced a set of
tslib
-like JS polyfills in the utils package. Because they live in a non-traditional place, they don't automatically get included in the tarball we publish to npm. This fixes that, by adding a utils-specific prepack script to copy them into the build directory. It also adds the resulting tarballs to.gitignore
, so this can be tested locally without polluting the working tree.There's no test to prove that this works, but here is the result of running
yarn build:npm
in the utils package: