Skip to content

fix(build): Add JS polyfills to utils tarball #5029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented May 4, 2022

UPDATE: This is no longer necessary, and is therefore getting closed.

This is a follow-up to #5023, which introduced a set of tslib-like JS polyfills in the utils package. Because they live in a non-traditional place, they don't automatically get included in the tarball we publish to npm. This fixes that, by adding a utils-specific prepack script to copy them into the build directory. It also adds the resulting tarballs to .gitignore, so this can be tested locally without polluting the working tree.

There's no test to prove that this works, but here is the result of running yarn build:npm in the utils package:

image

@lobsterkatie lobsterkatie force-pushed the kmclb-add-polyfills-to-utils-tarball branch from 9c5d391 to 6dda61c Compare May 4, 2022 03:07
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 18.73 KB (-7% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 58.55 KB (-9.39% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.54 KB (-7% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 52.73 KB (-9.05% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.2 KB (-17.38% 🔽)
@sentry/browser - Webpack (minified) 62.07 KB (-24.05% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.22 KB (-17.43% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 42.9 KB (-10.74% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 24.51 KB (-6.02% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.09 KB (-5.71% 🔽)

@lobsterkatie lobsterkatie force-pushed the kmclb-add-polyfills-to-utils-tarball branch from 6dda61c to 9b564f8 Compare May 4, 2022 20:50
@lobsterkatie
Copy link
Member Author

Because of changes in #5051, this is no longer needed.

@AbhiPrasad AbhiPrasad deleted the kmclb-add-polyfills-to-utils-tarball branch January 30, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant