Skip to content

ref(transports): Add back client reports #4998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Apr 27, 2022

This PR mainly aims to add back client reports to the SDK using the new transports:

Contents

  • Make transport.send() return void instead of response information. We do not need that information.
  • Clean up transport types
    • Introduce DropReason type to use in place of Outcome to be more in line with our docs. Outcome is a very overloaded term. Outcome now describes an "outcome object" like the docs use the term:
    • Remove Response, EventStatus, SentryRequestType, SentryRequest types - were not needed anymore
    • Introduce DataCategory type in favor of TransportCategory to be more in line with the docs. We use it for client outcome categories and rate limit categories.
    • Introduce an EnvelopeItemType type.
  • Introduce function envelopeItemTypeToDataCategory to map from envelope item types to data categories. This mapping is taken from the python SDK.
  • Remove eventStatusFromHttpCode function. It is not needed anymore.
  • Add functionality to BaseClient to track dropped events
  • Send client reports in sdks

@lforst lforst added this to the 7.0.0 milestone Apr 27, 2022
@lforst lforst changed the base branch from master to 7.x April 27, 2022 15:38
@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 18.45 KB (-8.4% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 57.8 KB (-10.54% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.2 KB (-8.81% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 51.97 KB (-10.35% 🔽)
@sentry/browser - Webpack (gzipped + minified) 21.06 KB (-9.38% 🔽)
@sentry/browser - Webpack (minified) 72.94 KB (-10.74% 🔽)
@sentry/react - Webpack (gzipped + minified) 21.09 KB (-9.4% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 46.07 KB (-4.13% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 24.22 KB (-7.12% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 22.72 KB (-7.19% 🔽)

@lforst lforst closed this Apr 28, 2022
@lforst lforst deleted the lforst-v7-new-client-outcomes branch May 11, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant