fix(types): Point to type definitions in dist folder #4745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Mar 21, 2022
AbhiPrasad
approved these changes
Mar 21, 2022
This kinda reverts parts of c17b752
lforst
force-pushed
the
lforst-hotfix-typedef-entrypoint
branch
from
d2a32d4 to
ac53c46
Compare
size-limit report
|
|
@lforst @AbhiPrasad Do these files ( |
Lms24
added a commit
that referenced
this pull request
Mar 31, 2022
…ints (#4824) * All tarballs now include the `build/types` directory. All `.npmignore`s were adjusted to include this directory. * The `types` entry point in all `package.json`s are now adjusted to the new types directory Proper bugfix for 6.19.0 regression: With PR #4724, we introduced separate building of type declaration files which would be written to `<sdk>/build/types`. Furthermore, we adjusted the `types` entry point in the `package.json`s to this new directory. To avoid a breaking change, we kept type declarations in `dist` and `esm`. However, a bug in this PR caused a small regression in most of our SDKs: The new types directory was not included in most of our SDK tarballs. Subsequently, we released a hot fix via #4745 which simply reset the entry points back to their previous path (`dist/index.d.ts`) in all SDKs. Additional adjustments w.r.t. creating tarballs to improve consistency: * Browser: Adjusted `postbuild.sh` to copy `.npmignore` to `./build` * Gatsby: Use `.npmignore` instead of `files` property in `package.json` * Utils: Changed `.npmignore` to be more similar to our other packages * WASM: Changed `.npmignore` to be more similar to our other packages * Next.js: Added `.npmignore`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4744
#4724 introduced an issue where we point to type definitions in the
buildfolder. For some reason, this build folder did not get published in the build artefact.This PR changes the pointer to the type definitions back to where we know they exist. We will update this again in the future.