Skip to content

ref(build): Build types separately #4724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 18, 2022
Merged

ref(build): Build types separately #4724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9f68132
add types-specific tsconfig template
lobsterkatie Mar 15, 2022
ec4de5b
add types tsconfig to packages
lobsterkatie Mar 15, 2022
4cdbb00
add `build:types` and `build:types:watch` commands to packages
lobsterkatie Mar 16, 2022
c8ccfea
add ts-node
lobsterkatie Mar 17, 2022
db907de
add `build:types` and `build:types:watch` commands to main package.json
lobsterkatie Mar 16, 2022
f6810e4
add `build:types` and `build:types:watch` to `build`, `build:dev`, `b…
lobsterkatie Mar 16, 2022
1f2c96e
set package.json's `types` property to new output location
lobsterkatie Mar 16, 2022
e84ffa8
add todo to main tsconfig.json
lobsterkatie Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@
"build:dev:filter": "lerna run --stream --concurrency 1 --sort build:dev --include-filtered-dependencies --include-filtered-dependents --scope",
"build:es5": "yarn lerna run --stream --concurrency 1 --sort build:cjs # *** backwards compatibility - remove in v7 ***",
"build:esm": "lerna run --stream --concurrency 1 --sort build:esm",
"build:types": "lerna run --stream --concurrency 1 --sort build:types",
"build:watch": "lerna run --parallel build:watch",
"build:dev:watch": "lerna run --parallel build:dev:watch",
"build:types:watch": "ts-node scripts/build-types-watch.ts",
"circularDepCheck": "lerna run --parallel circularDepCheck",
"clean": "lerna run --parallel clean && lerna clean --yes",
"codecov": "codecov",
Expand Down Expand Up @@ -82,6 +84,8 @@
"sinon": "^7.3.2",
"size-limit": "^4.5.5",
"ts-jest": "^24.3.0",
"ts-node": "^10.7.0",
"tslib": "^2.3.1",
"typedoc": "^0.18.0",
"typescript": "3.7.5"
},
Expand Down
8 changes: 5 additions & 3 deletions packages/angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"main": "dist/index.js",
"module": "esm/index.js",
"types": "dist/index.d.ts",
"types": "build/types/index.d.ts",
"publishConfig": {
"access": "public"
},
Expand All @@ -33,16 +33,18 @@
"@angular/router": "^10.0.3"
},
"scripts": {
"build": "run-p build:cjs build:esm",
"build": "run-p build:cjs build:esm build:types",
"build:cjs": "tsc -p tsconfig.cjs.json",
"build:dev": "run-s build",
"build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***",
"build:esm": "tsc -p tsconfig.esm.json",
"build:watch": "run-p build:cjs:watch build:esm:watch",
"build:types": "tsc -p tsconfig.types.json",
"build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch",
"build:cjs:watch": "tsc -p tsconfig.cjs.json --watch",
"build:dev:watch": "run-s build:watch",
"build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***",
"build:esm:watch": "tsc -p tsconfig.esm.json --watch",
"build:types:watch": "tsc -p tsconfig.types.json --watch",
"circularDepCheck": "madge --circular src/index.ts",
"clean": "rimraf dist esm build coverage",
"fix": "run-s fix:eslint fix:prettier",
Expand Down
10 changes: 10 additions & 0 deletions packages/angular/tsconfig.types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "./tsconfig.json",

"compilerOptions": {
"declaration": true,
"declarationMap": true,
"emitDeclarationOnly": true,
"outDir": "build/types"
}
}
12 changes: 7 additions & 5 deletions packages/browser/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"main": "dist/index.js",
"module": "esm/index.js",
"types": "dist/index.d.ts",
"types": "build/types/index.d.ts",
"publishConfig": {
"access": "public"
},
Expand Down Expand Up @@ -44,18 +44,20 @@
"webpack": "^4.30.0"
},
"scripts": {
"build": "run-p build:cjs build:esm build:bundle",
"build": "run-p build:cjs build:esm build:bundle build:types",
"build:bundle": "rollup --config",
"build:cjs": "tsc -p tsconfig.cjs.json",
"build:dev": "run-p build:cjs build:esm",
"build:dev": "run-p build:cjs build:esm build:types",
"build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***",
"build:esm": "tsc -p tsconfig.esm.json",
"build:watch": "run-p build:cjs:watch build:esm:watch build:bundle:watch",
"build:types": "tsc -p tsconfig.types.json",
"build:watch": "run-p build:cjs:watch build:esm:watch build:bundle:watch build:types:watch",
"build:bundle:watch": "rollup --config --watch",
"build:cjs:watch": "tsc -p tsconfig.cjs.json --watch",
"build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***",
"build:dev:watch": "run-p build:cjs:watch build:esm:watch",
"build:dev:watch": "run-p build:cjs:watch build:esm:watch build:types:watch",
"build:esm:watch": "tsc -p tsconfig.esm.json --watch",
"build:types:watch": "tsc -p tsconfig.types.json --watch",
"circularDepCheck": "madge --circular src/index.ts",
"clean": "rimraf dist esm build coverage .rpt2_cache",
"fix": "run-s fix:eslint fix:prettier",
Expand Down
10 changes: 10 additions & 0 deletions packages/browser/tsconfig.types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "./tsconfig.json",

"compilerOptions": {
"declaration": true,
"declarationMap": true,
"emitDeclarationOnly": true,
"outDir": "build/types"
}
}
8 changes: 5 additions & 3 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"main": "dist/index.js",
"module": "esm/index.js",
"types": "dist/index.d.ts",
"types": "build/types/index.d.ts",
"publishConfig": {
"access": "public"
},
Expand All @@ -23,16 +23,18 @@
"tslib": "^1.9.3"
},
"scripts": {
"build": "run-p build:cjs build:esm",
"build": "run-p build:cjs build:esm build:types",
"build:cjs": "tsc -p tsconfig.cjs.json",
"build:dev": "run-s build",
"build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***",
"build:esm": "tsc -p tsconfig.esm.json",
"build:watch": "run-p build:cjs:watch build:esm:watch",
"build:types": "tsc -p tsconfig.types.json",
"build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch",
"build:cjs:watch": "tsc -p tsconfig.cjs.json --watch",
"build:dev:watch": "run-s build:watch",
"build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***",
"build:esm:watch": "tsc -p tsconfig.esm.json --watch",
"build:types:watch": "tsc -p tsconfig.types.json --watch",
"circularDepCheck": "madge --circular src/index.ts",
"clean": "rimraf dist esm coverage",
"fix": "run-s fix:eslint fix:prettier",
Expand Down
10 changes: 10 additions & 0 deletions packages/core/tsconfig.types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "./tsconfig.json",

"compilerOptions": {
"declaration": true,
"declarationMap": true,
"emitDeclarationOnly": true,
"outDir": "build/types"
}
}
8 changes: 5 additions & 3 deletions packages/gatsby/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"main": "dist/index.js",
"module": "esm/index.js",
"types": "dist/index.d.ts",
"types": "build/types/index.d.ts",
"files": [
"/dist",
"/esm",
Expand All @@ -40,16 +40,18 @@
"react": "^17.0.0"
},
"scripts": {
"build": "run-p build:cjs build:esm",
"build": "run-p build:cjs build:esm build:types",
"build:cjs": "tsc -p tsconfig.cjs.json",
"build:dev": "run-s build",
"build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***",
"build:esm": "tsc -p tsconfig.esm.json",
"build:watch": "run-p build:cjs:watch build:esm:watch",
"build:types": "tsc -p tsconfig.types.json",
"build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch",
"build:cjs:watch": "tsc -p tsconfig.cjs.json --watch",
"build:dev:watch": "run-s build:watch",
"build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***",
"build:esm:watch": "tsc -p tsconfig.esm.json --watch",
"build:types:watch": "tsc -p tsconfig.types.json --watch",
"circularDepCheck": "madge --circular src/index.ts",
"clean": "rimraf dist esm build coverage",
"fix": "run-s fix:eslint fix:prettier",
Expand Down
10 changes: 10 additions & 0 deletions packages/gatsby/tsconfig.types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "./tsconfig.json",

"compilerOptions": {
"declaration": true,
"declarationMap": true,
"emitDeclarationOnly": true,
"outDir": "build/types"
}
}
8 changes: 5 additions & 3 deletions packages/hub/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"main": "dist/index.js",
"module": "esm/index.js",
"types": "dist/index.d.ts",
"types": "build/types/index.d.ts",
"publishConfig": {
"access": "public"
},
Expand All @@ -21,16 +21,18 @@
"tslib": "^1.9.3"
},
"scripts": {
"build": "run-p build:cjs build:esm",
"build": "run-p build:cjs build:esm build:types",
"build:cjs": "tsc -p tsconfig.cjs.json",
"build:dev": "run-s build",
"build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***",
"build:esm": "tsc -p tsconfig.esm.json",
"build:watch": "run-p build:cjs:watch build:esm:watch",
"build:types": "tsc -p tsconfig.types.json",
"build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch",
"build:cjs:watch": "tsc -p tsconfig.cjs.json --watch",
"build:dev:watch": "run-s build:watch",
"build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***",
"build:esm:watch": "tsc -p tsconfig.esm.json --watch",
"build:types:watch": "tsc -p tsconfig.types.json --watch",
"circularDepCheck": "madge --circular src/index.ts",
"clean": "rimraf dist esm coverage",
"fix": "run-s fix:eslint fix:prettier",
Expand Down
10 changes: 10 additions & 0 deletions packages/hub/tsconfig.types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "./tsconfig.json",

"compilerOptions": {
"declaration": true,
"declarationMap": true,
"emitDeclarationOnly": true,
"outDir": "build/types"
}
}
10 changes: 6 additions & 4 deletions packages/integrations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"main": "dist/index.js",
"module": "esm/index.js",
"types": "dist/index.d.ts",
"types": "build/types/index.d.ts",
"dependencies": {
"@sentry/types": "6.18.2",
"@sentry/utils": "6.18.2",
Expand All @@ -25,17 +25,19 @@
"chai": "^4.1.2"
},
"scripts": {
"build": "run-p build:cjs build:esm build:bundle",
"build": "run-p build:cjs build:esm build:types build:bundle",
"build:bundle": "bash scripts/buildBundles.sh",
"build:cjs": "tsc -p tsconfig.cjs.json",
"build:dev": "run-s build:cjs build:esm",
"build:dev": "run-s build:cjs build:esm build:types",
"build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***",
"build:esm": "tsc -p tsconfig.esm.json",
"build:watch": "run-p build:cjs:watch build:esm:watch",
"build:types": "tsc -p tsconfig.types.json",
"build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch",
"build:cjs:watch": "tsc -p tsconfig.cjs.json --watch",
"build:dev:watch": "run-s build:watch",
"build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***",
"build:esm:watch": "tsc -p tsconfig.esm.json --watch",
"build:types:watch": "tsc -p tsconfig.types.json --watch",
"circularDepCheck": "madge --circular src/index.ts",
"clean": "rimraf dist esm build coverage .rpt2_cache",
"fix": "run-s fix:eslint fix:prettier",
Expand Down
10 changes: 10 additions & 0 deletions packages/integrations/tsconfig.types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "./tsconfig.json",

"compilerOptions": {
"declaration": true,
"declarationMap": true,
"emitDeclarationOnly": true,
"outDir": "build/types"
}
}
8 changes: 5 additions & 3 deletions packages/minimal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"main": "dist/index.js",
"module": "esm/index.js",
"types": "dist/index.d.ts",
"types": "build/types/index.d.ts",
"publishConfig": {
"access": "public"
},
Expand All @@ -21,16 +21,18 @@
"tslib": "^1.9.3"
},
"scripts": {
"build": "run-p build:cjs build:esm",
"build": "run-p build:cjs build:esm build:types",
"build:cjs": "tsc -p tsconfig.cjs.json",
"build:dev": "run-s build",
"build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***",
"build:esm": "tsc -p tsconfig.esm.json",
"build:watch": "run-p build:cjs:watch build:esm:watch",
"build:types": "tsc -p tsconfig.types.json",
"build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch",
"build:cjs:watch": "tsc -p tsconfig.cjs.json --watch",
"build:dev:watch": "run-s build:watch",
"build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***",
"build:esm:watch": "tsc -p tsconfig.esm.json --watch",
"build:types:watch": "tsc -p tsconfig.types.json --watch",
"circularDepCheck": "madge --circular src/index.ts",
"clean": "rimraf dist esm coverage",
"fix": "run-s fix:eslint fix:prettier",
Expand Down
10 changes: 10 additions & 0 deletions packages/minimal/tsconfig.types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "./tsconfig.json",

"compilerOptions": {
"declaration": true,
"declarationMap": true,
"emitDeclarationOnly": true,
"outDir": "build/types"
}
}
8 changes: 5 additions & 3 deletions packages/nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"main": "./dist/index.server.js",
"module": "./esm/index.server.js",
"browser": "./esm/index.client.js",
"types": "./esm/index.server.d.ts",
"types": "./build/types/index.server.d.ts",
"publishConfig": {
"access": "public"
},
Expand Down Expand Up @@ -43,16 +43,18 @@
}
},
"scripts": {
"build": "run-p build:cjs build:esm",
"build": "run-p build:cjs build:esm build:types",
"build:cjs": "tsc -p tsconfig.cjs.json",
"build:dev": "run-s build",
"build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***",
"build:esm": "tsc -p tsconfig.esm.json",
"build:watch": "run-p build:cjs:watch build:esm:watch",
"build:types": "tsc -p tsconfig.types.json",
"build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch",
"build:cjs:watch": "tsc -p tsconfig.cjs.json --watch",
"build:dev:watch": "run-s build:watch",
"build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***",
"build:esm:watch": "tsc -p tsconfig.esm.json --watch",
"build:types:watch": "tsc -p tsconfig.types.json --watch",
"circularDepCheck": "madge --circular src/index.client.ts && madge --circular --exclude 'config/types\\.ts' src/index.server.ts # see https://github.com/pahen/madge/issues/306",
"clean": "rimraf dist esm coverage *.js *.js.map *.d.ts",
"fix": "run-s fix:eslint fix:prettier",
Expand Down
10 changes: 10 additions & 0 deletions packages/nextjs/tsconfig.types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "./tsconfig.json",

"compilerOptions": {
"declaration": true,
"declarationMap": true,
"emitDeclarationOnly": true,
"outDir": "build/types"
}
}
8 changes: 5 additions & 3 deletions packages/node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"main": "dist/index.js",
"module": "esm/index.js",
"types": "dist/index.d.ts",
"types": "build/types/index.d.ts",
"publishConfig": {
"access": "public"
},
Expand All @@ -34,16 +34,18 @@
"nock": "^13.0.5"
},
"scripts": {
"build": "run-p build:cjs build:esm",
"build": "run-p build:cjs build:esm build:types",
"build:cjs": "tsc -p tsconfig.cjs.json",
"build:dev": "run-s build",
"build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***",
"build:esm": "tsc -p tsconfig.esm.json",
"build:watch": "run-p build:cjs:watch build:esm:watch",
"build:types": "tsc -p tsconfig.types.json",
"build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch",
"build:cjs:watch": "tsc -p tsconfig.cjs.json --watch",
"build:dev:watch": "run-s build:watch",
"build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***",
"build:esm:watch": "tsc -p tsconfig.esm.json --watch",
"build:types:watch": "tsc -p tsconfig.types.json --watch",
"circularDepCheck": "madge --circular src/index.ts",
"clean": "rimraf dist esm coverage",
"fix": "run-s fix:eslint fix:prettier",
Expand Down
10 changes: 10 additions & 0 deletions packages/node/tsconfig.types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "./tsconfig.json",

"compilerOptions": {
"declaration": true,
"declarationMap": true,
"emitDeclarationOnly": true,
"outDir": "build/types"
}
}
Loading