Skip to content

ref(core): Use helpers with session envelopes #4655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2022

Conversation

AbhiPrasad
Copy link
Member

This patch converts the sessions logic in packages/core/src/request.ts
to use the recently introduced envelope helpers.

ref: #4587

Resolves https://getsentry.atlassian.net/browse/WEB-626

@AbhiPrasad AbhiPrasad requested review from a team, Lms24 and lobsterkatie and removed request for a team March 1, 2022 15:18
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022

size-limit report

Path Base Size (fb5d4e6) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.75 KB 19.74 KB -0.02% 🔽
@sentry/browser - ES5 CDN Bundle (minified) 63.3 KB 63.26 KB -0.08% 🔽
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.42 KB 18.41 KB -0.05% 🔽
@sentry/browser - ES6 CDN Bundle (minified) 56.44 KB 56.39 KB -0.09% 🔽
@sentry/browser - Webpack (gzipped + minified) 22.2 KB 22.19 KB -0.03% 🔽
@sentry/browser - Webpack (minified) 76.23 KB 76.18 KB -0.06% 🔽
@sentry/react - Webpack (gzipped + minified) 22.23 KB 22.22 KB -0.03% 🔽
@sentry/nextjs Client - Webpack (gzipped + minified) 46.39 KB 46.39 KB -0.02% 🔽
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.63 KB 26.63 KB -0.02% 🔽

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 1, 2022 16:14
AbhiPrasad and others added 2 commits March 2, 2022 10:44
This patch converts the sessions logic in `packages/core/src/request.ts`
to use the recently introduced envelope helpers.

ref: #4587
@AbhiPrasad AbhiPrasad force-pushed the abhi-session-envelope branch from 977df6c to e2378f1 Compare March 2, 2022 15:44
@AbhiPrasad AbhiPrasad merged commit fcdb458 into master Mar 2, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-session-envelope branch March 2, 2022 15:56
@AbhiPrasad AbhiPrasad added this to the Pre 7.0.0 Work milestone Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants