Skip to content

fix(browser): Reassign lastEventId while eliminating duplicate events. #4021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

fix(browser): Reassign lastEventId while eliminating duplicate events. #4021

wants to merge 4 commits into from

Conversation

onurtemizkan
Copy link
Collaborator

Fixes: #4018

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2021 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 22.39 KB (+0.34% 🔺)
@sentry/browser - Webpack 23.37 KB (+0.29% 🔺)
@sentry/react - Webpack 23.4 KB (+0.3% 🔺)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.84 KB (+0.23% 🔺)

@kamilogorek
Copy link
Contributor

Overall I think it might work fine. WDYT @getsentry/team-webplatform ?
We should also port it to integrations/dedupe in case someone is using it.

@AbhiPrasad
Copy link
Member

I’m fine with this approach

iker-barriocanal
iker-barriocanal suggested changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests?

And a question: is it possible the following flow happens?

  1. A duplicated event E is generated.
  2. Another event F is generated.
  3. The ID of event E is set as the last ID.
  4. The latest event ID corresponds to E, instead of F.

@rhcarvalho rhcarvalho mentioned this pull request Oct 4, 2021
Closed
4 tasks
@onurtemizkan
Copy link
Collaborator Author

Closing this, as lastEventId's behaviour needs to be clarified first (#4018 (comment)) and this is probably too specific.

@iker-barriocanal, thanks. I'm now working on a new PR to add a test suite for dedupe integration. 👍

@onurtemizkan onurtemizkan deleted the onur/dedupe-last-event-id branch October 7, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iker-barriocanal iker-barriocanal iker-barriocanal requested changes

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lastEventId is wrong when errors are Deduped
4 participants
@onurtemizkan @kamilogorek @AbhiPrasad @iker-barriocanal