Skip to content

Add react-native docs #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2015
Merged

Add react-native docs #388

merged 1 commit into from
Oct 28, 2015

Conversation

benvinegar
Copy link
Contributor

Depends on #387

@dcramer
Copy link
Member

dcramer commented Oct 8, 2015

There is also the config.json file in docs root I think that we should add blurbs too

@mattrobenolt
Copy link
Contributor

plz to merge?

benvinegar added a commit that referenced this pull request Oct 28, 2015
@benvinegar benvinegar merged commit d2ab38b into master Oct 28, 2015
@benvinegar benvinegar deleted the react-native-docs branch October 28, 2015 19:46
@qbig
Copy link
Contributor

qbig commented Jan 12, 2016

Hi @benvinegar could I ask why we would need the line

var React = require('react');

in index file ?

@benvinegar
Copy link
Contributor Author

You don't. It was just there to demonstrate "this is a React app". It should probably be removed.

@qbig
Copy link
Contributor

qbig commented Jan 12, 2016

I see. got quite confused as my code looks like this

var React = require('react-native');
require('regenerator/runtime');
var {
  AppRegistry
} = React;

@qbig
Copy link
Contributor

qbig commented Jan 12, 2016

Thanks ! @benvinegar

@qbig
Copy link
Contributor

qbig commented Jan 12, 2016

Hi @benvinegar , according to docs

So for example, if you have http://example.com/app.min.js, and the file contains the reference to app.map.js, the name of the uploaded file should be http://example.com/app.map.js.

But in the generated bundle file for react native, it always ends with

//# sourceMappingURL=bundle.js

Does this mean that I had to name my sourcemap output to "bundle.js" as well ?

like

--sourcemap-output android/app/src/main/assets/bundle.js

@benvinegar
Copy link
Contributor Author

Yes. It's odd that React native would name it bundle.js and not something like bundle.js.map.

@qbig – btw, if you need a hand with sourcemaps and/or our React integration, you should contact support (if you are a hosted customer) or leave a message on the Sentry Google Group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants