Replace old-style require(console) with a global object #3623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kamilogorek hey, pretty sure this PR is a minor one. Could you please review it? |
> console
> const c = require('console')
> console === c
trueThey are effectively that same objects so it's safe to change it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #2 thing that was a blocker for me while I was trying to start using
@sentry/nodein a Forge app. I investigated where this code comes from and I didn't find (or I didn't understand) a good reason why "console" needs to be be Node.JS-required instead of just using a global object which is available even in Node.JS 6.The tests are not failing for me here so I assume this should be a safe change?