Improved solution to issue #179 (invalid options throwing errors in joinRegExp) #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rors in joinRegExp)
This slightly more robust solution ignores options that are not strings
or regular expressions in the passed patterns array.
The prior solution still accepted non-string, non-regexp options (e.g.
[], {}, true, etc.).
Credit goes to @soundslocke for the fix.
| // If it's a string, we need to escape it | ||
| // Taken from: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions | ||
| sources.unshift(patterns[i].replace(/([.*+?^=!:${}()|\[\]\/\\])/g, "\\$1")); | ||
| } else if (!isUndefined(patterns[i]) && patterns[i] && patterns[i].source) { |
There was a problem hiding this comment.
Is it necessary to check again for isUndefined? Wouldn't just patterns[i] && patterns[i].source be enough?
|
|
|
I have no problem moving to a normal for loop and away from The changes will be pushed again soon. |
```unshift``` is significantly slower than ```push```. Shift towards using ```push``` and remove a redundant conditional.
Likely [benefits](http://stackoverflow.com/questions/6261953/do-modern-javascript-jiters-need-array-length-caching-in-loops) the performance of older browsers that lack smart caching. Thanks again to @soundslocke for the heads up.
|
This looks sensible to me. Thanks for the contribution! 👍 I'll cut a new release today. |
mattrobenolt
added a commit
that referenced
this pull request
Jan 12, 2014
Improved solution to issue #179 (invalid options throwing errors in joinRegExp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly more robust solution ignores options that are not strings
or regular expressions in the passed patterns array.
The prior solution still accepted non-string, non-regexp options (e.g.
[], {}, true, etc.).
Credit goes to @soundslocke for the fix.