Skip to content

feat(react-router): Create low quality transactions filter for react router #16219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

RulaKhaled
Copy link
Contributor

@RulaKhaled RulaKhaled commented May 7, 2025

Filter out server side noisy transactions triggered by http integration from react-router. Fixes: #16161

@RulaKhaled RulaKhaled requested a review from chargome May 7, 2025 15:17
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!
Not sure, something to look at in a follow up, but does the logic we have for nuxt make sense where we ignore all requests to files with ending (e.g. GET asdasd.png)? 🤔 but this is something to iterate on :)

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🥇

@chargome
Copy link
Member

chargome commented May 8, 2025

Not sure, something to look at in a follow up, but does the logic we have for nuxt make sense where we ignore all requests to files with ending (e.g. GET asdasd.png)?

@mydea good point but we need to make sure not to filter e.g. /some/route.data as we depend on that atm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RR7] Add server-side transaction noise filter
4 participants