feat(react-router): Add otel instrumentation for server requests #16147
+412
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chargome
commented
May 12, 2025
|
|
||
| // Set the source and overwrite attributes on the root span to ensure the transaction name | ||
| // is derived from the raw URL pathname rather than any parameterized route that may be set later | ||
| // TODO: try to set derived parameterized route from build here (args[0]) |
There was a problem hiding this comment.
want to ship this in a follow-up
andreiborza
reviewed
May 13, 2025
...2e-tests/test-applications/react-router-7-framework/app/routes/performance/dynamic-param.tsx
Show resolved
Hide resolved
| get(target, prop, receiver) { | ||
| if (prop === 'createRequestHandler') { | ||
| const original = target[prop]; | ||
| return function wrappedCreateRequestHandler(this: unknown, ...args: unknown[]) { |
There was a problem hiding this comment.
Suggested change
| return function wrappedCreateRequestHandler(this: unknown, ...args: unknown[]) { | |
| return function sentryWrappedCreateRequestHandler(this: unknown, ...args: unknown[]) { |
l: Can we prefix this with sentry? :)
| return function wrappedCreateRequestHandler(this: unknown, ...args: unknown[]) { | ||
| const originalRequestHandler = original.apply(this, args); | ||
|
|
||
| return async function wrappedRequestHandler(request: Request, initialContext?: unknown) { |
There was a problem hiding this comment.
Suggested change
| return async function wrappedRequestHandler(request: Request, initialContext?: unknown) { | |
| return async function sentryWrappedRequestHandler(request: Request, initialContext?: unknown) { |
l: and this one too
| overwrite | ||
| ) { | ||
| event.transaction = overwrite; | ||
| delete event.contexts?.trace?.data?.[SEMANTIC_ATTRIBUTE_SENTRY_OVERWRITE]; |
There was a problem hiding this comment.
q: Can this attribute end up on transactions that don't match all those conditions above and thus won't be deleted? Does that matter? I'm wondering if we should just always delete at the end of the processor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds OpenTelemetry instrumentation for server-side requests in React Router by tracing server requests for data loaders and actions.