Skip to content

build(browser): Add function export in minified bundle for micro frontends #14925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

philippeVV
Copy link

@philippeVV philippeVV commented Jan 7, 2025

Add the function makeMultiplexedTransport from @sentry/core to the export in the browser package.
Make the function available in the browser minified bundle.

This function is required to use Sentry Micro Frontend.

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @philippeVV, thanks for opening this PR! makeMultiplexedTransport is currently only exported from the NPM package, you're right. But there's a reason for it: Bundle size would increase for all CDN bundle users, while multiplexed transport usage is rather the exception than the norm. Before we merge this, I'd like to check if we can find an alternative solution. Is there a way you could use the NPM package instead of the CDN bundles?

@philippeVV
Copy link
Author

Hey @Lms24, sorry for the late response. I went back to discuss with my team and review the application, but it's a legacy project that would be to costly to refactor. Realistically, we wouldn't be able to prioritize it and would have to stay with the status quo.

@Lms24
Copy link
Member

Lms24 commented Jan 17, 2025

Hey @philippeVV thanks a lot for contributing! After discussing this internally (also raised in #15041), we decided to go down a bit of a different route to avoid the bundle size increase of the SDK bundle. See #15043.

I'll therefore close this PR. Thanks!

@Lms24 Lms24 closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants