Skip to content

test: Skip double installing playwright in E2E tests #14633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 10, 2024

We do install this on CI separately before, so this should not be necessary (esp. we do not need firefox, as we only run these tests on chromium).

This should shave off about 20s of the build step for all the E2E tests!

We do install this on CI separately before, so this should not be necessary (esp. we do not need firefox, as we only run these tests on chromium).
@mydea mydea self-assigned this Dec 10, 2024
Copy link
Contributor

github-actions bot commented Dec 10, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.27 KB - -
@sentry/browser - with treeshaking flags 21.94 KB - -
@sentry/browser (incl. Tracing) 35.75 KB - -
@sentry/browser (incl. Tracing, Replay) 72.98 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.38 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 77.29 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.78 KB - -
@sentry/browser (incl. Feedback) 40.02 KB - -
@sentry/browser (incl. sendFeedback) 27.88 KB - -
@sentry/browser (incl. FeedbackAsync) 32.67 KB - -
@sentry/react 25.94 KB - -
@sentry/react (incl. Tracing) 38.58 KB - -
@sentry/vue 27.47 KB - -
@sentry/vue (incl. Tracing) 37.59 KB - -
@sentry/svelte 23.43 KB - -
CDN Bundle 24.41 KB - -
CDN Bundle (incl. Tracing) 37.4 KB - -
CDN Bundle (incl. Tracing, Replay) 72.6 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.96 KB - -
CDN Bundle - uncompressed 71.69 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.97 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 225.04 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 238.26 KB - -
@sentry/nextjs (client) 38.86 KB - -
@sentry/sveltekit (client) 36.26 KB - -
@sentry/node 162.23 KB +0.01% +2 B 🔺
@sentry/node - without tracing 98.42 KB - -
@sentry/aws-serverless 126.11 KB - -

View base workflow run

Copy link

codecov bot commented Dec 10, 2024

❌ 152 Tests Failed:

Tests completed Failed Passed Skipped
693 152 541 300
View the top 3 failed tests by shortest run time
server/server-component-error.test.ts Should capture an error thrown in a server component
Stack Traces | 0.003s run time
server-component-error.test.ts:4:5 Should capture an error thrown in a server component
errors.test.ts sets correct transactionName
Stack Traces | 0.006s run time
errors.test.ts:32:5 sets correct transactionName
performance.test.ts sends a navigation transaction even if the pageload span is still active
Stack Traces | 0.006s run time
performance.test.ts:57:5 sends a navigation transaction even if the pageload span is still active

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@mydea mydea marked this pull request as ready for review December 10, 2024 10:00
@mydea mydea requested review from lforst and andreiborza December 10, 2024 10:00
@mydea mydea changed the title test: Skip installing playwright in E2E tests all the time test: Skip double installing playwright in E2E tests Dec 10, 2024
@@ -984,7 +985,7 @@ jobs:

# - We skip optional tests on release branches
job_optional_e2e_tests:
name: E2E ${{ matrix.label || matrix.test-application }} Test
name: E2E ${{ matrix.label || matrix.test-application }} Test (optional)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also took this opportunity to name this clearer!

@mydea mydea merged commit a9dcdb8 into develop Dec 10, 2024
161 checks passed
@mydea mydea deleted the fn/skip-double-playwright branch December 10, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants