Skip to content

ci: Fix canary test implosion #12915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2024
Merged

ci: Fix canary test implosion #12915

merged 4 commits into from
Jul 15, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Jul 15, 2024

Quite random that this fixes it but 🤷 https://github.com/getsentry/sentry-javascript/actions/runs/9938503884

The nextjs 15 failures are actual failures I think

fixes #12905
fixes #12813
fixes #12906
fixes #12909
fixes #12902
fixes #12908

@lforst lforst marked this pull request as ready for review July 15, 2024 11:47
@lforst lforst requested review from Lms24 and andreiborza July 15, 2024 11:47
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I have so many questions...

  • why is this only now a problem?
  • why does this fix things?

but thanks a lot for figuring it out!

@lforst
Copy link
Contributor Author

lforst commented Jul 15, 2024

Hmm I have so many questions...

  • why is this only now a problem?
  • why does this fix things?

but thanks a lot for figuring it out!

I had the exact same questions but can not answer them.

@lforst lforst merged commit 05b2754 into develop Jul 15, 2024
121 checks passed
@lforst lforst deleted the lforst-try-fix-canary-implosion branch July 15, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants