fix: Cleanup hooks when they are not used anymore #12852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
approved these changes
Jul 10, 2024
Small optimization using the new hook cleanup capabilities to remove unused hooks.
mydea
commented
Jul 11, 2024
| @@ -288,7 +288,7 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio | |||
| return; | |||
| } | |||
|
|
|||
| if (activeSpan) { | |||
| if (activeSpan && !spanToJSON(activeSpan).timestamp) { | |||
There was a problem hiding this comment.
While debugging a test failure, I noticed that this surfaced another problem - we were potentially double-ending the span here. If the idle span already ended on it's own, we do not want to/need to end it anymore here! Calling this twice lead to some issues as it tried to remove the hooks twice, ...
mydea
commented
Jul 11, 2024
| const cbIndex = hooks.indexOf(callback); | ||
| // @ts-expect-error We assue the types are correct | ||
| const cbIndex = hooks.indexOf(callback); | ||
| if (cbIndex > -1) { |
There was a problem hiding this comment.
Also adding this safeguard that was missing before - if trying to remove a hook twice, this should not fail and remove the first entry or similar.
This was referenced Aug 7, 2024
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimization using the new hook cleanup capabilities to remove unused hooks.
Ref PR to do this in angular: #12786