Skip to content

fix(otel): Do not add otel.kind: INTERNAL attribute #12841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 10, 2024

Only add this if this is some other value, e.g. CLIENT or SERVER. It is useless to have the internal value there and potentially confusing (why is this there? what does internal even mean?)

@mydea mydea self-assigned this Jul 10, 2024
Copy link
Contributor

github-actions bot commented Jul 10, 2024

size-limit report 📦

Path Size
@sentry/browser 22.29 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing) 33.44 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) 69.19 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.52 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.25 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.88 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.74 KB (-0.02% 🔽)
@sentry/browser (incl. metrics) 26.58 KB (-0.05% 🔽)
@sentry/browser (incl. Feedback) 38.97 KB (-0.03% 🔽)
@sentry/browser (incl. sendFeedback) 26.92 KB (-0.04% 🔽)
@sentry/browser (incl. FeedbackAsync) 31.53 KB (-0.03% 🔽)
@sentry/react 25.04 KB (-0.06% 🔽)
@sentry/react (incl. Tracing) 36.48 KB (-0.04% 🔽)
@sentry/vue 26.4 KB (-0.05% 🔽)
@sentry/vue (incl. Tracing) 35.3 KB (-0.04% 🔽)
@sentry/svelte 22.43 KB (-0.07% 🔽)
CDN Bundle 23.51 KB (-0.05% 🔽)
CDN Bundle (incl. Tracing) 35.2 KB (-0.03% 🔽)
CDN Bundle (incl. Tracing, Replay) 69.31 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.5 KB (-0.02% 🔽)
CDN Bundle - uncompressed 69 KB (-0.04% 🔽)
CDN Bundle (incl. Tracing) - uncompressed 104.02 KB (-0.03% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed 214.41 KB (-0.02% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 227.12 KB (-0.01% 🔽)
@sentry/nextjs (client) 36.36 KB (-0.04% 🔽)
@sentry/sveltekit (client) 34.09 KB (-0.04% 🔽)
@sentry/node 130.81 KB (+0.01% 🔺)
@sentry/node - without tracing 91.89 KB (+0.02% 🔺)
@sentry/aws-serverless 117.06 KB (+0.01% 🔺)

@mydea mydea force-pushed the fn/remove-otel-kind branch from d9e2c63 to f210f0e Compare July 10, 2024 09:39
@mydea mydea merged commit 196fc09 into develop Jul 10, 2024
105 checks passed
@mydea mydea deleted the fn/remove-otel-kind branch July 10, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants