test: Port onerror tests to playwright #11543
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
reviewed
Apr 11, 2024
Comment on lines
+1
to
+5
| function throwStringError() { | ||
| throw 'stringError'; | ||
| } | ||
|
|
||
| throwStringError(); |
There was a problem hiding this comment.
The problem with this code is that it throws an error immediately when the subject script is evaluated by the browser. This results in the infamous Script Error which the SDK filters by default. If you enable debug logging you should see that the error gets dropped by the SDK.
I usually add a click listener to a button and click it in the test to work around this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.