Skip to content

feat: Remove tags from spans & transactions #10809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 26, 2024

We've refactored all usage away, now we can actually get rid of the tags on the span themselves.

@mydea mydea requested review from Lms24 and AbhiPrasad February 26, 2024 12:22
@mydea mydea self-assigned this Feb 26, 2024
Copy link
Contributor

github-actions bot commented Feb 26, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.5 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.75 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.65 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.3 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.98 KB (-0.18% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 32.98 KB (-0.18% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.36 KB (-0.01% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.36 KB (-0.02% 🔽)
@sentry/browser - Webpack (gzipped) 22.56 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - CDN Bundle (gzipped) 75.59 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing, Replay) - CDN Bundle (gzipped) 67.19 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing) - CDN Bundle (gzipped) 33.05 KB (-0.1% 🔽)
@sentry/browser - CDN Bundle (gzipped) 24.01 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) - CDN Bundle (minified & uncompressed) 210.89 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing) - CDN Bundle (minified & uncompressed) 99.69 KB (-0.13% 🔽)
@sentry/browser - CDN Bundle (minified & uncompressed) 71.74 KB (-0.02% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.99 KB (-0.08% 🔽)
@sentry/react - Webpack (gzipped) 22.6 KB (-0.02% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.47 KB (-0.02% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 49.87 KB (-0.07% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.41 KB (-0.02% 🔽)

@mydea mydea force-pushed the fn/stop-using-span-tags branch 3 times, most recently from c237db8 to deab246 Compare February 27, 2024 12:28
Base automatically changed from fn/stop-using-span-tags to develop February 27, 2024 15:08
@mydea mydea force-pushed the fn/remove-span-tags branch from 81db979 to 4173525 Compare March 7, 2024 16:53
@mydea mydea marked this pull request as ready for review March 7, 2024 16:53
@mydea mydea requested review from lforst and s1gr1d March 7, 2024 16:53
@mydea mydea enabled auto-merge (squash) March 7, 2024 17:31
@mydea mydea disabled auto-merge March 7, 2024 17:32
@mydea mydea merged commit 4b261ce into develop Mar 7, 2024
@mydea mydea deleted the fn/remove-span-tags branch March 7, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants