You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's a bug where events other than click and keypress will automatically be tracked as breadcrumbs; this is particularly annoying for mousemove events since they'll fill up the breadcrumbs list with junk really quickly.
The problem is that the addEventListener monkeypatch wraps every listener function but only specifies a before breadcrumb handler for click and keypress event types. However, wrap will automatically reuse a previous wrapper for a function with no regard for differences in the _before argument (bug apparently introduced in commit 99cf147. So if click wraps a function first then all events will generate breadcrumbs, but if another event type wraps the function first then click won't generate breadcrumbs either.
This issue is particularly acute with jQuery, which uses a single event handling function per element for all event types, but applies to any code that attaches the same listener function to both click and other events.
The text was updated successfully, but these errors were encountered:
Hey @pkaminski. Your description makes sense. When I get the next opportunity I'll develop a patch. Interestingly, despite breadcrumbs being out for months, you're the first person to raise this issue.
There's a bug where events other than
click
andkeypress
will automatically be tracked as breadcrumbs; this is particularly annoying formousemove
events since they'll fill up the breadcrumbs list with junk really quickly.The problem is that the
addEventListener
monkeypatch wraps every listener function but only specifies abefore
breadcrumb handler forclick
andkeypress
event types. However,wrap
will automatically reuse a previous wrapper for a function with no regard for differences in the_before
argument (bug apparently introduced in commit 99cf147. So ifclick
wraps a function first then all events will generate breadcrumbs, but if another event type wraps the function first thenclick
won't generate breadcrumbs either.This issue is particularly acute with jQuery, which uses a single event handling function per element for all event types, but applies to any code that attaches the same listener function to both
click
and other events.The text was updated successfully, but these errors were encountered: