Skip to content

Breadcrumb added for every mousemove event #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pkaminski opened this issue Sep 5, 2016 · 3 comments
Closed

Breadcrumb added for every mousemove event #724

pkaminski opened this issue Sep 5, 2016 · 3 comments
Assignees

Comments

@pkaminski
Copy link
Contributor

There's a bug where events other than click and keypress will automatically be tracked as breadcrumbs; this is particularly annoying for mousemove events since they'll fill up the breadcrumbs list with junk really quickly.

The problem is that the addEventListener monkeypatch wraps every listener function but only specifies a before breadcrumb handler for click and keypress event types. However, wrap will automatically reuse a previous wrapper for a function with no regard for differences in the _before argument (bug apparently introduced in commit 99cf147. So if click wraps a function first then all events will generate breadcrumbs, but if another event type wraps the function first then click won't generate breadcrumbs either.

This issue is particularly acute with jQuery, which uses a single event handling function per element for all event types, but applies to any code that attaches the same listener function to both click and other events.

@pkaminski
Copy link
Contributor Author

Ping @benvinegar?

@benvinegar
Copy link
Contributor

Hey @pkaminski. Your description makes sense. When I get the next opportunity I'll develop a patch. Interestingly, despite breadcrumbs being out for months, you're the first person to raise this issue.

@benvinegar benvinegar self-assigned this Sep 9, 2016
@pkaminski
Copy link
Contributor Author

Huh, guess jQuery isn't as popular as it used to be... Thanks in advance, I think this is the last thing blocking my upgrade to v3.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants