-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Convert React Native plugin to use HTTP POST #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@benvinegar So how is eg. python client handle the CORS headers etc ? |
So, if you use your secret key with a regular POST, it will work. But you're not supposed to share your secret key, and I believe the key will be visible if embedded in your React Native app. |
Just wondering why would the key be visible ? |
or maybe an temporary fix to limit the length of stack trace to like 1000 characters ? |
@benvinegar Nice! I just figured out that, if I limit the length of the stacktrace message, I can get log info ! |
Change react-native plugin to use HTTP POST w/ phony Origin (fixes #493)
We are getting reports that React Native produces particularly long stack traces, and the HTTP GETs produced by Raven.js are causing 414 "URI too long" errors.
Unfortunately, this isn't as simple as just switching "GET" to "POST" ... The Sentry server requires CORS headers, which React Native's "emulated" XHR may not support (for example, React Native does not support
withCredentials
). Need to investigate.The text was updated successfully, but these errors were encountered: