Skip to content

2.0.1 throws errors with Google Maps API. #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jgerigmeyer opened this issue Jan 8, 2016 · 3 comments
Closed

2.0.1 throws errors with Google Maps API. #458

jgerigmeyer opened this issue Jan 8, 2016 · 3 comments

Comments

@jgerigmeyer
Copy link
Contributor

Sorry in advance for being a bit vague, but I'm having trouble nailing down exactly what's going on here. I have an app that uses the Google Maps API. After upgrading from raven-js 1.3.0 to 2.0.1, I'm consistently getting errors when the map settles after "flicking" to pan the map (i.e. click and drag with some speed, let go and allow the momentum to continue panning the map until it settles).

Example: https://jsfiddle.net/jgerigmeyer/zkbqjcsu/

TypeError: Cannot read property 'Ja' of null
  at wrapped(/assets/raven.bundle.js:325:30)
  at _.t.oo(/maps-api-v3/api/js/23/4/common.js:228:106)
  at _.t.nn(/maps-api-v3/api/js/23/4/common.js:254:38)
  at Object._.H.trigger(/maps/api/js:88:121)
  at null.<anonymous>(/maps-api-v3/api/js/23/4/common.js:197:441)
  at Nw(/maps-api-v3/api/js/23/4/common.js:198:140)
  at Object._.H.trigger(/maps/api/js:88:121)
  at _.t.Kl(/maps-api-v3/api/js/23/4/common.js:241:70)
@benvinegar
Copy link
Contributor

@jgerigmeyer – so, I've been playing with this for a bit (debugging Google Maps' minified code), and the issue appears related to the addEventListener wrapping we do in 2.0.0 (as part of our goal to get more complete stack traces in all browsers).

Still digging 'cause this is tricky to step through. I recommend reverting to 1.3.0 in the meantime.

@jgerigmeyer
Copy link
Contributor Author

👍 Thanks for digging into it! I started wading through their minified code, and quickly found myself over my head... :)

@benvinegar
Copy link
Contributor

@jgerigmeyer – we will push 2.0.2 with the fix this afternoon. Thanks for your help.

benvinegar added a commit that referenced this issue Jan 9, 2016
Fix missing return value in requestAnimationFrame wrapper (fixes #458)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants