-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Avoid recursion when using the console plugin #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@mattrobenolt @benvinegar If the root issue is too hard to fix, may I suggest again that (at least temporarily) logDebug only call console.log instead of obeying it's level parameter? This will avoid triggering the console plugin, and still give us our output. What do you think? |
@benoitg Yeah, I think that's reasonable for now. |
benoitg
added a commit
to benoitg/raven-js
that referenced
this issue
Aug 25, 2015
…ng raven-js when both the console plugin is loaded and Raven.debug===true.
Patch in #374 |
benvinegar
added a commit
that referenced
this issue
Aug 25, 2015
Preserve original console methods (fixes #373)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ok, let's try to clarify:
Issue is that logDebug in sentry causes infinite recursion if Raven.debug is true and the console plugin is used.
Test case (still failing as of today):
The text was updated successfully, but these errors were encountered: