feat: Update Expandable style
#12457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For this, I extracted the `Alert` component stuff into a more generic `Callout` component, which the `Alert` extends. The `Expandable` can now use the same basis, ensuring we have the same style etc, and just pass some more stuff into it. For this, the `Callout` component also allows to pass `id` and `titleOnClick` attributes which we need for the Expandable.
mydea
requested review from
inventarSarah,
Jesse-Box,
stephanie-anderson and
chargome
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 2.03kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
View changes by path for bundle: sentry-docs-server-cjs
|
mydea
commented
Jan 24, 2025
| } | ||
|
|
||
| .callout-content { | ||
| min-width: 0; |
There was a problem hiding this comment.
Without this, e.g. code boxes can lead to exceeding the width of the content. this should "fix" this.
Jesse-Box
approved these changes
Jan 24, 2025
chargome
requested changes
Jan 24, 2025
src/components/callout/index.tsx
Outdated
| } | ||
|
|
||
| // We want to avoid actually triggering the link | ||
| const wrappedOnClick = onClick |
There was a problem hiding this comment.
would move this into a useCallback
There was a problem hiding this comment.
I changed it, better like this?
src/components/expandable.tsx
Outdated
|
|
||
| export function Expandable({title, children, permalink}: Props) { | ||
| const [isExpanded, setIsExpanded] = useState(false); | ||
| const defaultIsExpanded = id && window.location.hash === `#${id}`; |
There was a problem hiding this comment.
we'll need to move this into an effect to avoid hydration errors
stephanie-anderson
approved these changes
Jan 24, 2025
JoshuaMoelans
pushed a commit
that referenced
this pull request
Jan 27, 2025
This was referenced Jan 27, 2025
jan-auer
added a commit
that referenced
this pull request
Jan 28, 2025
…zation-settings * master: (511 commits) docs(cloudflare): several semantic and stylistic fixes in code examples for cloudflare workers (#12482) chore(replay): Clarify network bandwidth and show how to reduce perf impact for mobile SDKs (#12479) chore(replay): Update product docs FAQ (#12474) ref: Drop remaining usage of `<Note>` (#12476) Update debugmeta.mdx (#12436) Fix queue_producer_transaction string termination error in example code (#12463) Adjust for sentry-ruby changes (#12455) Fixed incorrect instrument.mjs filename (#12454) Updating feature flags docs location (#12453) ref: Remove `<Note>` component in favor of using `<Alert>` (#12467) feat: send content feedback plausible events (#12400) docs(native): document how to set attribute on spans/transactions feat(express): Add warning about express v5 (#12465) chore(jira): Add instructions for installing Jira for self-hosted sentry users (#12433) chore: Update Codecov Bundler Plugin Version (#12459) Bump API schema to 421589ca (#12461) fix(platform): Enable scrolling via keyboard buttons (#12460) feat: Update `Expandable` style (#12457) Add Kotlin examples and fix typo in Java and Android Scopes docs (#12458) doc(js): Document how to set attribute on all spans (#12449) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this, I extracted the
Alertcomponent stuff into a more genericCalloutcomponent, which theAlertextends.The
Expandablecan now use the same basis, ensuring we have the same style etc, and just pass some more stuff into it.For this, the
Calloutcomponent also allows to passidandtitleOnClickattributes which we need for the Expandable.Before
After
Permalinks
I made sure that permalinks continue to work. I tweaked the behavior a bit, now it does not scroll into view when you open a permalink expandable, this should be a bit more subtle now. You can try the behavior on any Troubleshoot page in the JS repo, for example.