Migrate the FlutterSampleNotificationProvider to the new EditorNotificationProvider API (#7840) #7842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwren
force-pushed
the
FlutterSampleNotificationProvider_7830
branch
from
9e618af to
d22385f
Compare
pq
approved these changes
Dec 4, 2024
| return getSamplesFromDoc(flutterPackagePath, document, filePath); | ||
| }); | ||
|
|
||
| return samples.isEmpty() ? null : new FlutterSampleActionsPanel(samples); | ||
| if (samples != null && !samples.isEmpty()) { |
There was a problem hiding this comment.
Can samples be null here or can you skip this check? (It looks like getSamplesFromDoc at worst returns an empty list?)
There was a problem hiding this comment.
ApplicationManager.getApplication() and runReadAction can actually be null, hence this check.
There was a problem hiding this comment.
Ah! So maybe this is new Java. I would have expected ApplicationManager.getApplication(). runReadAction to throw an NPE if getApplication returns null, but cool!
| } | ||
|
|
||
| private List<FlutterSample> getSamplesFromDoc(String flutterPackagePath, Document document, String filePath) { | ||
| private List<FlutterSample> getSamplesFromDoc(@NotNull String flutterPackagePath, @NotNull Document document, @NotNull String filePath) { |
…cationProvider API (flutter#7840) This is progress on flutter#7830
jwren
force-pushed
the
FlutterSampleNotificationProvider_7830
branch
from
d22385f to
9f87257
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is progress on #7830