Skip to content

Bazel run config mnemonics (and cleanup). #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2016
Merged

Bazel run config mnemonics (and cleanup). #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/io/flutter/inspections/SdkConfigurationNotificationProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ private static EditorNotificationPanel createWrongSdkPanel(@NotNull Project proj
return panel;
}

@SuppressWarnings("SameReturnValue")
private static EditorNotificationPanel createNoFlutterSdkPanel() {
// TODO(pq): add panel for unconfigured Flutter SDK.

Expand Down
1 change: 1 addition & 0 deletions src/io/flutter/run/FlutterDebugProcess.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ public boolean shouldEnableHotReload() {
return ((FlutterAppState)myState).getMode().isReloadEnabled();
}

@SuppressWarnings("BooleanMethodIsAlwaysInverted")
private boolean isDebuggingSession() {
return isDebuggingSession(myState);
}
Expand Down
6 changes: 3 additions & 3 deletions src/io/flutter/run/bazel/FlutterBazelConfigurationEditorForm.form
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<properties>
<inheritsPopupMenu value="true"/>
<labelFor value="17e7b"/>
<text value="Launching script:"/>
<text value="Launching &amp;script:"/>
</properties>
</component>
<component id="17e7b" class="com.intellij.openapi.ui.TextFieldWithBrowseButton" binding="myLaunchingScript">
Expand All @@ -57,7 +57,7 @@
</constraints>
<properties>
<labelFor value="ada9e"/>
<text value="Additional args:"/>
<text value="Additional &amp;args:"/>
</properties>
</component>
<component id="ada9e" class="javax.swing.JTextField" binding="myAdditionalArgs">
Expand All @@ -72,7 +72,7 @@
</constraints>
<properties>
<labelFor value="ada9f"/>
<text value="Bazel build target:"/>
<text value="Bazel build &amp;target:"/>
</properties>
</component>
<component id="ada9f" class="javax.swing.JTextField" binding="myBuildTarget">
Expand Down
2 changes: 1 addition & 1 deletion src/io/flutter/run/daemon/FlutterDaemonController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ private static GeneralCommandLine createBazelRunner(@NotNull Project project,
boolean isHot,
@NotNull String launchingScript,
@NotNull String bazelTarget,
@Nullable String additionalArguments) throws ExecutionException {
@Nullable String additionalArguments) {
final GeneralCommandLine commandLine = new GeneralCommandLine().withWorkDirectory(projectDir);
commandLine.setCharset(CharsetToolkit.UTF8_CHARSET);
commandLine.setExePath(FileUtil.toSystemDependentName(launchingScript));
Expand Down
2 changes: 1 addition & 1 deletion src/io/flutter/run/daemon/FlutterDaemonControllerHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ void process(FlutterDaemonControllerHelper manager, FlutterDaemonController cont

private static class AppStoppedEvent extends Event {
// "event":"app.stop"
@SuppressWarnings("unused") private String appId;
@SuppressWarnings({"unused", "CanBeFinal"}) private String appId;

void process(FlutterDaemonControllerHelper manager, FlutterDaemonController controller) {
manager.eventAppStopped(this);
Expand Down
3 changes: 0 additions & 3 deletions ...t/src/com/jetbrains/lang/dart/ide/runner/server/vmService/DartVmServiceDebugProcessZ.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,6 @@ public void logInformation(final String message, final Throwable exception) {
});
}

public void scheduleConnect() {
}

public void scheduleConnectNew() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the parent implementation do? Does this method (even an empty implementation) effect behavior?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered the same thing but there's no parent implementation --- the closest is scheduleConnect(String) which has a different signature obviously and is private.

ApplicationManager.getApplication().executeOnPooledThread(() -> {
if (myConnector != null) {
Expand Down