[Flight] land enableHalt flag
#33111
Open
+23
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
gnoff
force-pushed
the
flight-land-enable-halt
branch
from
81f8be0 to
6efea5f
Compare
gnoff
force-pushed
the
flight-land-enable-halt
branch
from
6efea5f to
ffde9b7
Compare
gnoff
force-pushed
the
flight-land-enable-halt
branch
from
ffde9b7 to
79765b7
Compare
gnoff
force-pushed
the
flight-land-enable-halt
branch
from
79765b7 to
96017d3
Compare
enableHalt was added as a flag to experiment with a new semantic for prerendering RSC results. In particular we model RSC aborts for prerenders as unfinished streams where models awaiting a value will never get them. This sets the stage for resuming RSC renders in the future where we can expect a concategnation and continuation of the RSC result picking up the holes left by the aborted prerender. Prerender is already an unstable API and there is no future for the non-halting semantics so this commit lands the flag. This change doesn't remove the flag entirely because halt semantics are also available while prerendering Fizz in the experimental channel. This API is not unstable and is more widely used so when we adopt the experimental behavior in a canary we should be closer to releasing the next major
gnoff
force-pushed
the
flight-land-enable-halt
branch
from
96017d3 to
9f0b209
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enableHalt was added as a flag to experiment with a new semantic for prerendering RSC results. In particular we model RSC aborts for prerenders as unfinished streams where models awaiting a value will never get them. This sets the stage for resuming RSC renders in the future where we can expect a concategnation and continuation of the RSC result picking up the holes left by the aborted prerender. Prerender is already an unstable API and there is no future for the non-halting semantics so this commit lands the flag.
This change doesn't remove the flag entirely because halt semantics are also available while prerendering Fizz in the experimental channel. This API is not unstable and is more widely used so when we adopt the experimental behavior in a canary we should be closer to releasing the next major