Wire endTransmission() fix for issue #1725 #1888
Merged
+1
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having both endTransmission(bool) and endTransmission(uint8_t) creates problems. There is no need for endTransmission(uint8_t) endTransmission(1) and endTransmission(0) works with endTransmission(bool). Removing endTransmission(uint8_t) allows the ESP32 code to be compatible with all the other Arduino cores by allowing endTransmission(1) and endTranmission(0) to work as it does on all the other cores.
This was referenced Sep 22, 2018
|
Hey thanks! Sorry for the delay :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will fix issue #1725
There is no need to have the uint8_t version of the endTransmission() function.
Having both endTransmission(uint8_t) and endTransmission(bool) creates problems. The biggest problem being that endTransmission(0) and endTransmission(1) won't compile like it does on all the other cores.
Simply removing endTransmission(uint8_t) solves the problem.