Skip to content

WiFi disconnect reason message updated #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2018
Merged

Conversation

rmshub
Copy link
Contributor

@rmshub rmshub commented Apr 16, 2018

wifi_err_reason_t doesn't have reason code 12. After reason code 11, we are getting wrong wifi disconnected reason message. Added "UNSPECIFIED" in place of reason code 12.
And above 201 reason code, it should be r-176 instead of r-177. Because messages are started from zeroth offset.

wifi_err_reason_t doesn't have reason code 12. After reason code 11, we are getting wrong wifi disconnected reason message. Added "UNSPECIFIED"  in place of reason code 12.
And above 201 reason code, it should be r-176 instead of r-177. Because messages are started from zeroth offset.
@tablatronix
Copy link
Contributor

ahh this probably explains my PR

486b813

Shouldn't this PR contain the esp_wifi_type.h change also ?

@rmshub
Copy link
Contributor Author

rmshub commented Apr 24, 2018

ESP32 Arduino library build over ESP-IDF. So, WiFi event reasons should be match with esp_wifi_type.h. WiFi reason 12 should be unspecified instead of changing into 177. Because, 486b813 fix works only wifi reasons after 176 but not for between 12 and 176. If esp_wifi_type.h is updated, then WiFi reasons should be change accordingly.

@tablatronix
Copy link
Contributor

tablatronix commented Apr 24, 2018

Yeah but my point is your pr does not fix code 12 in esp_wifi_type.h, so it still does not address the issue there.
You should add index 12 and revert my pr, and add to the system_event_reasons array right ?

@tablatronix
Copy link
Contributor

I mean they should probably match for clarity ?

@tablatronix
Copy link
Contributor

@me-no-dev this PR is the proper fix for #1132
I faileld to notice index 12 is missing from system_event_reasons causing this one off issue.

index 12 is also missing from wifi_err_reason_t, but is not addressed by this.

@rmshub
Copy link
Contributor Author

rmshub commented Apr 25, 2018

Yeah. My PR is not fix WiFI reason code in esp_wifi_type.h because we don't know exactly it is missed accidentally or they defined WiFi error code with some valid cause. If it is missed accidentally, then it is required to address esp_wifi_type.h and then update Wifi reason messages accordingly.

@tablatronix
Copy link
Contributor

Maybe we should insert a comment there..

@me-no-dev me-no-dev merged commit f14de5c into espressif:master May 14, 2018
@me-no-dev
Copy link
Member

thanks!

@rmshub rmshub deleted the patch-1 branch June 8, 2018 07:46
Curclamas pushed a commit to Curclamas/arduino-esp32 that referenced this pull request Aug 21, 2018
wifi_err_reason_t doesn't have reason code 12. After reason code 11, we are getting wrong wifi disconnected reason message. Added "UNSPECIFIED"  in place of reason code 12.
And above 201 reason code, it should be r-176 instead of r-177. Because messages are started from zeroth offset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants