-
Notifications
You must be signed in to change notification settings - Fork 7.6k
WiFi disconnect reason message updated #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wifi_err_reason_t doesn't have reason code 12. After reason code 11, we are getting wrong wifi disconnected reason message. Added "UNSPECIFIED" in place of reason code 12. And above 201 reason code, it should be r-176 instead of r-177. Because messages are started from zeroth offset.
ahh this probably explains my PR Shouldn't this PR contain the esp_wifi_type.h change also ? |
ESP32 Arduino library build over ESP-IDF. So, WiFi event reasons should be match with esp_wifi_type.h. WiFi reason 12 should be unspecified instead of changing into 177. Because, 486b813 fix works only wifi reasons after 176 but not for between 12 and 176. If esp_wifi_type.h is updated, then WiFi reasons should be change accordingly. |
Yeah but my point is your pr does not fix code 12 in esp_wifi_type.h, so it still does not address the issue there. |
I mean they should probably match for clarity ? |
@me-no-dev this PR is the proper fix for #1132 index 12 is also missing from wifi_err_reason_t, but is not addressed by this. |
Yeah. My PR is not fix WiFI reason code in esp_wifi_type.h because we don't know exactly it is missed accidentally or they defined WiFi error code with some valid cause. If it is missed accidentally, then it is required to address esp_wifi_type.h and then update Wifi reason messages accordingly. |
Maybe we should insert a comment there.. |
thanks! |
wifi_err_reason_t doesn't have reason code 12. After reason code 11, we are getting wrong wifi disconnected reason message. Added "UNSPECIFIED" in place of reason code 12. And above 201 reason code, it should be r-176 instead of r-177. Because messages are started from zeroth offset.
wifi_err_reason_t doesn't have reason code 12. After reason code 11, we are getting wrong wifi disconnected reason message. Added "UNSPECIFIED" in place of reason code 12.
And above 201 reason code, it should be r-176 instead of r-177. Because messages are started from zeroth offset.