Fix PIO toolchain by ensuring IRQ vectors in link #6088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIO uses GCC in a way that causes the compiler to optimize away the IRQ vectors (since they're not used in our code itself) in the final build stage. We can avoid this by forcing all of libmain to be included in the final object. This is a small file, and almost completely related to IRQs, so space impact is minimal. Fixes esp8266#6087 and platformio/platform-espressif8266#147
|
Sorry, was AFK. Thank you for testing that. Note that platformio does not use platform.txt to build, but using SCons that runs platformio-build.py script. Some quick research at https://stackoverflow.com/questions/22122498/how-do-i-add-whole-archive-linker-option-in-scons advices on modifying LINKFLAGS variable and excluding it from LIBS Arduino/tools/platformio-build.py Line 123 in 98125f8 |
Since PIO doesn't use platform.txt, shoehorn the same change as in platform.txt to the PIO build script.
|
Actually, since I can't test this I'm going to close it. If someone using PIO can give it a go, please open a new PR w/the needed changes. |
|
Also just discovered that the PIO linking way loses other bits of IRAM so this wasn't a complete fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIO uses GCC in a way that causes the compiler to optimize away the IRQ
vectors (since they're not used in our code itself) in the final build
stage.
We can avoid this by forcing all of libmain to be included in the final
object. This is a small file, and almost completely related to IRQs, so
space impact is minimal.
Fixes #6087 and
platformio/platform-espressif8266#147