Skip to content

device tests: updates for esptool.py #6084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2019

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented May 13, 2019

Makefile new rule: 'make distclean' removes virtualenv
attempt to use python3 (python2 is still default)

d-a-v added 2 commits May 13, 2019 15:53
Makefile new rule: 'make distclean' removes virtualenv
attempt to use python3 (python2 is still default)
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing jumps out at me :)

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@earlephilhower earlephilhower merged commit 818a55f into esp8266:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants