Make BearSSL::write() blocking #4804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlephilhower
force-pushed
the
partialwrite
branch
from
8117380 to
1037af8
Compare
When a message is sent by the app that is larger than the SSL buffer, it will take multiple TLS fragments to transfer. Writes will loop through and not return until either all data is transferred or there is an error.
earlephilhower
force-pushed
the
partialwrite
branch
from
1037af8 to
53fdfb5
Compare
|
Just tested this patch sending a 4096 byte char[] to an openssl s_server and it went through fine using the default 512b send fragment size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a message is sent by the app that is larger than the SSL buffer,
it will take multiple TLS fragments to transfer. Writes will now
loop through and not complete until either all data is transferred
or there is an error.
The prior behavior caused an error in HTTPClient (and others) as it would only write the first chunk (i.e. 512b by default) and return "512" no matter how large the app write request was. Unless the app was expecting this and trying it in a loop, this would either cause a protocol error if the app did not check write's return value, or an app error if it detected the short write.