Skip to content

Added support for querying host IP numbers with the new method #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

pilotniq
Copy link

@pilotniq pilotniq commented Oct 7, 2016

Fix for issue #2584

Introduces new method:

IPAddress queryHost( const chat *host );

Please review the consequences for service queries, I've made some changes to the parsePacket code.

@codecov-io
Copy link

codecov-io commented Oct 7, 2016

Current coverage is 27.80% (diff: 100%)

Merging #2585 into master will not change coverage

@@             master      #2585   diff @@
==========================================
  Files            20         20          
  Lines          3625       3625          
  Methods         335        335          
  Messages          0          0          
  Branches        656        656          
==========================================
  Hits           1008       1008          
  Misses         2441       2441          
  Partials        176        176          

Powered by Codecov. Last update 4897e00...e8596f4

@me-no-dev
Copy link
Collaborator

I actually have a reworked parser ready for wider testing that follows MDNS compression and extracts better the information from the answers. That includes names, texts and addresses from host or service searches.
Will post it soon as I expect most of the code to be portable to ESP32 also.
Maybe you will want to contribute to that if I have missed something.

@pilotniq
Copy link
Author

pilotniq commented Oct 7, 2016

me-no-dev: Sounds good. My commit also has a new query function, as the old one could only query for services. Have you redone the queries as well?

@me-no-dev
Copy link
Collaborator

here is the current status: https://gist.github.com/me-no-dev/e13b507a6e850af6cef733b1b35d9923
it's based on AsyncUDP but that is not an issue in this case

@earlephilhower earlephilhower added waiting for feedback Waiting on additional info. If it's not received, the issue may be closed. component: MDNS labels Jan 25, 2019
@earlephilhower
Copy link
Collaborator

Thanks for your PR, but MDNS has been completely rewritten with this release, so this PR can't apply anymore without massive rework.

I'll leave open for two weeks and come back after Feb 10 and see if there's interest from the original submitter. If not, will close then.

@d-a-v d-a-v closed this May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: MDNS waiting for feedback Waiting on additional info. If it's not received, the issue may be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants