Run code formatter on lib/mix/lib/mix/utils.ex #6872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyouhide
requested changes
Oct 11, 2017
lib/mix/lib/mix/utils.ex
Outdated
| File.cp_r!(source, target, fn orig, dest -> | ||
| File.stat!(orig).mtime > File.stat!(dest).mtime | ||
| end) | ||
| } |
There was a problem hiding this comment.
Please extract to variables and write the tuple on a single line as described in #6643.
lib/mix/lib/mix/utils.ex
Outdated
| Data does not match the given SHA-512 checksum. | ||
|
|
||
| Expected: #{expected} | ||
| Actual: #{actual} | ||
| """} | ||
| """ | ||
| } |
maartenvanvliet
force-pushed
the
master
branch
from
22db6b1 to
2229914
Compare
|
Fixed |
josevalim
reviewed
Oct 11, 2017
lib/mix/lib/mix/utils.ex
Outdated
|
|
||
| case :elixir_utils.read_mtime_and_size(path) do | ||
| {:ok, mtime, size} when mtime > now -> | ||
| Mix.shell.error("warning: mtime (modified time) for \"#{path}\" was set to the future, resetting to now") | ||
| Mix.shell().error( | ||
| "warning: mtime (modified time) for \"#{path}\" was set to the future, resetting to now" |
There was a problem hiding this comment.
Please extract the message to a variable.
|
Hi @maartenvanvliet, there are a couple more comments from @whatyouhide and myself pending. Thank you! |
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #6643