Format and clean up crash-course #1638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doughsay
commented
Sep 21, 2022
Comment on lines
+444
to
+446
| HelloModule.Utils.util() | ||
| # "Utilize" | ||
| #=> :ok |
There was a problem hiding this comment.
Wasn't quite sure how to show here that there's stdout printing in addition to a return value.
Comment on lines
624
to
+630
| f = fn | ||
| {:a, :b} = tuple -> | ||
| IO.puts "All your #{inspect tuple} are belong to us" | ||
| [] -> | ||
| "Empty" | ||
| end | ||
| {:a, :b} = tuple -> | ||
| "All your #{inspect(tuple)} are belong to us" | ||
|
|
||
| [] -> | ||
| "Empty" | ||
| end |
There was a problem hiding this comment.
Removing the IO.puts feels right to me here, but it causes it to differ from the Erlang example. I don't know how to change the Erlang example to make it match.
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A friend of mine recently found this page, and when he asked me questions about it I saw that it was pretty outdated. I've gone and updated the formatting of at least all the Elixir code to match the modern formatter and idioms, but I'm not familiar enough with Erlang to know if those examples need updating or not.
Hope this helps, please let me know if I should change anything.