Raise exception for unsuccessful requests

[deanmalan]

Hi @elchicodepython, thank you for writing this package!

I've added a response.raise_for_status() call so that exceptions will be raised when the request did not return a 200 response. Otherwise, it's hard to know whether the request was a success or not.

This might be a breaking change for other users though so might I suggest that you bump the package's version to a new major version after this change? E.g. 1.0.0. :)

[elchicodepython]

Hello @delenamalan ! Thank for your PR. ❤️

I see the use case but I'm a little bit worry about raising requests specific exceptions as maybe in a future we implement a NocoDBClient using other library (that's the idea of the infra layer). I think that we should add some custom exceptions to be raised by any NocoDBClient. So this way the exceptions raised are from our domain and if we change the infra library or we add a new implementation the handling of this exceptions by the users keep working.

Something like...

exceptions.py

class NocoDBAPIError(Exception):
    ...

infra/requests_client.py

#A 
try:
    response.raise_for_status()
except except requests.exceptions.HTTPError:
    raise NocoDBApiError(url, code=response.status)

I can add it by myself but as I see you quite motivated I can let you to add it in this PR if you want. If not tell me please so I can add it during this weekend that I will have some free time there.

Is it good for you? 😄

[elchicodepython]

PR merged and package 1.0.0 published! Congrats @delenamalan 🚀 !!