Skip to content

Align overwriting of get_queryset in example app and documentation #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Sep 23, 2021

Fixes #487

Description of the Change

Make sure that in example app local queryset is used for filtering.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk September 23, 2021 17:24
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #979 (83b3516) into master (f8209c0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #979   +/-   ##
=======================================
  Coverage   96.82%   96.82%           
=======================================
  Files          65       65           
  Lines        3904     3904           
=======================================
  Hits         3780     3780           
  Misses        124      124           
Impacted Files Coverage Δ
example/views.py 94.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8209c0...83b3516. Read the comment docs.

@n2ygk n2ygk merged commit a6644eb into django-json-api:master Sep 23, 2021
@sliverc sliverc deleted the get_queryset_unify branch September 23, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document classes and overrides used in the example app
2 participants